Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] mail_save_as_template_security #1487

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented Nov 4, 2024

This module allows you to restrict the "Save as new template" button to
a specific group of users in the email sender wizard form.

T-5296

@Tisho99 Tisho99 marked this pull request as draft November 4, 2024 17:49
@Tisho99 Tisho99 changed the title [ADD] mail_restrict_save_as_template [15.0][ADD] mail_restrict_save_as_template Nov 4, 2024
@Tisho99 Tisho99 force-pushed the 15.0-add-mail_restrict_save_as_template branch 3 times, most recently from 86aa794 to 84882c2 Compare November 5, 2024 09:32
@Tisho99 Tisho99 marked this pull request as ready for review November 5, 2024 09:37
@Tisho99
Copy link
Author

Tisho99 commented Nov 5, 2024

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@HaraldPanten
Copy link

@etobella @pedrobaeza do you mind give us a hand to move it forward? 🙏

THX in advance!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 5, 2024
@pedrobaeza
Copy link
Member

Following other patterns, I suggest you to name it mail_save_as_template_security.

Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaraldPanten
Copy link

@Tisho99 Could you apply these changes? THX!

Following other patterns, I suggest you to name it mail_save_as_template_security.

@Tisho99 Tisho99 force-pushed the 15.0-add-mail_restrict_save_as_template branch from 84882c2 to 271f081 Compare November 6, 2024 12:55
@Tisho99 Tisho99 force-pushed the 15.0-add-mail_restrict_save_as_template branch from 271f081 to 58dcbbd Compare November 6, 2024 12:57
@Tisho99 Tisho99 changed the title [15.0][ADD] mail_restrict_save_as_template [15.0][ADD] mail_save_as_template_security Nov 6, 2024
@ValentinVinagre
Copy link
Contributor

@pedrobaeza ,do you think it's ok to merge? @Tisho99 has made the name change.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1487-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7c6b669 into OCA:15.0 Nov 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ddb7fd5. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 15.0-add-mail_restrict_save_as_template branch November 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants