-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] mail_save_as_template_security #1487
[15.0][ADD] mail_save_as_template_security #1487
Conversation
86aa794
to
84882c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
@etobella @pedrobaeza do you mind give us a hand to move it forward? 🙏 THX in advance! |
Following other patterns, I suggest you to name it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Tisho99 Could you apply these changes? THX!
|
84882c2
to
271f081
Compare
271f081
to
58dcbbd
Compare
@pedrobaeza ,do you think it's ok to merge? @Tisho99 has made the name change. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at ddb7fd5. Thanks a lot for contributing to OCA. ❤️ |
This module allows you to restrict the "Save as new template" button to
a specific group of users in the email sender wizard form.
T-5296