[16.0][IMP] mail_gateway: Allow to use expand on Gateway messages #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
force-pushed
the
16.0-gateway-expand
branch
2 times, most recently
from
19d10c0 to
7427d80
Compare
|
Now its green... although the fix isn't very nice.... |
pedrobaeza
reviewed
Nov 7, 2024
| @@ -66,6 +66,23 @@ class ResPartnerGatewayChannel(models.Model): | |||
| "res.company", related="gateway_id.company_id", store=True | |||
| ) | |||
|
|
|||
| def name_get(self): | |||
There was a problem hiding this comment.
Document why this method override.
|
The UI seems totally unordered:
Can you please fix it? |
Other OCA modules extending the composer add m2m fields with fixed relations. To avoid a glue module we try for the moment to add those manually. TT51108
|
fixed |
chienandalu
force-pushed
the
16.0-gateway-expand
branch
from
7427d80 to
8b6e6c4
Compare
pedrobaeza
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Working as expected. I merge as there's the implicit approval of @etobella:
/ocabot merge minor
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 3e7f58c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extending #1443
Just added dummy compatibility with
mail_attach_existing_attachmentandmail_composer_cc_bccTT51108 cc @Tecnativa
please check @etobella @pedrobaeza