Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mail_attach_existing_attachment_account from 14 to 16 #1508

Open
wants to merge 12 commits into
base: 16.0
Choose a base branch
from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 22, 2024

No description provided.

@sbidoul sbidoul marked this pull request as draft November 22, 2024 18:27
@sbidoul sbidoul marked this pull request as ready for review November 22, 2024 18:33
@sbidoul
Copy link
Member Author

sbidoul commented Nov 22, 2024

/ocabot migration mail_attach_existing_attachment_account

This remains useful for the Send and Print wizard on invoices.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 22, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 22, 2024
39 tasks
We show the field with the same technique as in the base module, which
improves the display, showing the label.
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works, tested it on runboat

image

tarteo added a commit to onesteinbv/addons-oca that referenced this pull request Dec 6, 2024
@pedrobaeza
Copy link
Member

pedrobaeza commented Dec 6, 2024

I wonder if applying a similar technique like OCA/web#2804 in the base module, we can avoid this module at all. cc @CarlosRoca13

@CarlosRoca13
Copy link
Contributor

CarlosRoca13 commented Dec 9, 2024

I wonder if applying a similar technique like OCA/web#2804 in the base module, we can avoid this module at all. cc @CarlosRoca13

@pedrobaeza I think it wouldn't apply in this case... The loading order is used for the assets. In this case, I believe the issue is that the wizard account.invoice.send is built from mail.compose.message, but it is done using _inherits, which requires adapting it in a certain way.

Although I am not entirely familiar with the module, perhaps @victoralmau can provide some insight on the matter.

@pedrobaeza
Copy link
Member

OK, thanks. It was just a random thought without digging deeper, as it's a nuisance to require this extension for accounting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants