[WIP][MIG] mass_mailing_custom_unsubscribe: Migration to 11.0 #279

chienandalu · 2018-05-25T16:56:16Z

Needs:

[FIX] website_mass_mailing: right unsubscribe model odoo/odoo#24969 to be merged

WIP as the contacts relation to the lists has changed quite a bit (now one mailing contact can belong to multiple lists) so some parts must be reworked.

cc @Tecnativa

yajo · 2018-05-28T07:10:49Z

Check those ❌ please

chienandalu · 2018-05-28T07:13:03Z

This WIP yet 😄 The module has to be reworked as the contact<->list relation has changed in v11

chienandalu · 2018-05-29T16:46:23Z

@yajo This bug odoo/odoo#24969 has to be fixed in order to get the tours working

rafaelbn · 2018-06-01T12:20:26Z

@yajo @chienandalu this FIX is needed yes odoo/odoo#24969 and we should propose it in OCB if Odoo don't accept it. Do we have an OPW?

yajo · 2018-06-04T11:19:52Z

mass_mailing_custom_unsubscribe/templates/mass_mailing_contact_reason.xml

@@ -14,7 +14,15 @@
           position="attributes">
        <attribute name="class" value="container o_unsubscribe_form_custom"/>
    </xpath>
-
+    <!---->


yajo · 2018-06-04T11:21:24Z

mass_mailing_custom_unsubscribe/models/mail_mass_mailing.py

@@ -31,5 +36,7 @@ def update_opt_out(self, email, res_ids, value):
                    "unsubscriber_id": "%s,%d" % (one._name, one.id),
                    "action": action,
                })
+            if model._name == 'mail.mass_mailing.contact':
+                pass


yajo · 2018-06-04T11:22:32Z

mass_mailing_custom_unsubscribe/models/mail_mass_mailing.py

        action = "unsubscription" if value else "subscription"
-        records = self.env[self.mailing_model_real].browse(res_ids)
+        records = self.env[model._name].browse(res_ids)


model.browse?

yajo · 2018-06-04T11:23:26Z

mass_mailing_custom_unsubscribe/models/mail_mass_mailing.py

@@ -12,13 +12,18 @@ class MailMassMailing(models.Model):
    def update_opt_out(self, email, res_ids, value):
        """Save unsubscription reason when opting out from mailing."""
        self.ensure_one()
+        model = self.env[self.mailing_model_real].with_context(
+            active_test=False)


🤔 why the context?

yajo · 2018-06-04T11:24:15Z

mass_mailing_custom_unsubscribe/static/src/js/partner.tour.js

@@ -39,7 +39,7 @@ odoo.define("mass_mailing_custom_unsubscribe.partner_tour",
            },
            {
                content: "Successfully unsubscribed",
-                trigger: "body:not(:has(#reason_form)) .alert-success:contains('Your changes have been saved.')",
+                trigger: "body:not(:has(#reason_form)) .alert-success:contains('You have been successfully unsubscribed!')",


What if you are subscribing? Shouldn't this be kept?

yajo · 2018-06-04T11:24:39Z

mass_mailing_custom_unsubscribe/templates/mass_mailing_contact_reason.xml

+        <li class="list-group-item">
+            <input type="checkbox" class="mail_list_checkbox" name="list_ids"
+                   t-att-value="contact_list['id']"
+                   t-att-checked="'checked' if contact['opt_out'] == False else None"/>


is instead of ==

yajo · 2018-06-04T11:50:19Z

mass_mailing_custom_unsubscribe/controllers/main.py

-                        contact.list_id <= mailing.contact_list_ids
+                        not any(contact.list_ids.mapped(
+                            'not_cross_unsubscriptable')) or
+                        contact.list_ids <= mailing.contact_list_ids


I think that, given upstream basically broke this in v11, you can just add a new qcontext key like this:

"lists": contact.list_ids | request.env["mail.mass_mailing.list"].search([["not_cross_unsubscriptable", "=", False]]),

Then iterate over those lists in the view and render 1 checkbox for each of them if contact is subscribed to any of them.

Then, when user checks some and unchecks others, record 1 mail.mass_mailing.unsubscription per contact+list combination.

…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.

- Imported last updates from v8. - Adapted to v9. - Added a saner default to `mass_mailing.salt` configuration parameter by reusing `database.secret` if available, hoping that some day odoo/odoo#12040 gets merged. - Updated README. - Increase security, drop backwards compatibility. Security got improved upstream, which would again break compatibility among current addon and future master upstream. I choose to break it now and keep it secured future-wise, so I drop the backwards compatibility features. - Includes tour tests. - Removes outdated tests. - Extends the mailing list management form when unsubscriber is a contact. - Adds a reason form even if he is not. - Avoids all methods that were not model-agnostic. [FIX][mass_mailing_custom_unsubscribe] Reasons noupdate After this fix, when you update the addon, you will not lose your customized reasons. [FIX] Compatibilize with mass_mailing_partner Current test code was based on the assumption that the `@api.model` decorator on `create()` ensured an empty recordset when running the method, but that's not true. This was causing an incompatibility betwee these tests and the `mass_mailing_partner` addon, which works assuming 0-1 recordsets. Now records are created from an empty recordset, and thus tests work everywhere. Update instructions If the user does not add the unsubscribe snippet, nothing will happen, so it's added to README to avoid confusion when testing/using the addon. [FIX] Use the right operator to preserve recordsets order Using `|=` sorts records at will each time (treating them as Python's `set`). Using `+=` always appends a record to the end of the set. Since we are using the record position in the set, this caused the test to work sometimes and fail other times. Now it works always.

* [IMP] mass_mailing_custom_unsubscribe: GDPR compliance - Record resubscriptions too. - Record action metadata. - Make ESLint happy. - Quick color-based action distinction in tree view. - Add useful quick groupings. - Display (un)subscription metadata. - Pivot & graph views.

pedrobaeza · 2018-06-12T12:36:16Z

Travis is still red

yajo

Great!

yajo · 2018-06-12T14:00:55Z

mass_mailing_custom_unsubscribe/hooks.py

+            # split in several contacts
+            vals = contact._convert_to_write(contact._cache)
+            vals.pop('list_ids', None)
+            for list in contact.list_ids:


I think you should use upper level methods for this, and don't override builtin list:

for contact in contacts: if len(contact.list_ids) <= 1: continue list_1 = contact.list_ids[0] for list_ in contact.list_ids - list_1: contact.copy({"list_ids": [(6, 0, list_.ids)]}) contact.list_ids = list_1

yajo · 2018-06-12T14:01:33Z

mass_mailing_custom_unsubscribe/readme/ROADMAP.rst

@@ -0,0 +1,11 @@
+* As version 11 has introduced a new relation type between mailing lists and
+  contacts that has multiple usability issues that are being reworked by Odoo
+  to land in version 12, this module fallsback to the version 10 behaviour in


yajo · 2018-06-12T14:01:39Z

mass_mailing_custom_unsubscribe/readme/ROADMAP.rst

+* As version 11 has introduced a new relation type between mailing lists and
+  contacts that has multiple usability issues that are being reworked by Odoo
+  to land in version 12, this module fallsback to the version 10 behaviour in
+  wich one contact belonged to just one list.


rafaelbn · 2018-06-12T15:11:58Z

all is 💚 here! Great! @yajo last technical review? I will test it functionally

yajo · 2018-06-12T15:19:21Z

It's just above 😉

chienandalu · 2018-06-12T15:41:35Z

@yajo Fixed

rafaelbn · 2018-06-12T16:04:55Z

@chienandalu 🤣 fixed? It was 🍏 now is 🔴

chienandalu · 2018-06-12T16:23:33Z

@rafaelbn 💚 as 🍏

yajo

Great!

Syncing from upstream OCA/social (12.0)

rafaelbn added this to the 11.0 milestone May 25, 2018

rafaelbn added the work in progress label May 25, 2018

rafaelbn requested review from yajo and rafaelbn May 25, 2018 17:50

rafaelbn assigned chienandalu May 25, 2018

rafaelbn added needs review and removed work in progress labels Jun 1, 2018

yajo reviewed Jun 4, 2018

View reviewed changes

yajo added work in progress and removed needs review labels Jun 4, 2018

antespi and others added 12 commits June 11, 2018 16:46

[ADD] mass_mailing_custom_unsubscribe addon

2bc8363

OCA Transbot updated translations from Transifex

8e7e712

[MIG] Make modules uninstallable

642eed9

[FIX] remove en.po that was erroneously created by transbot

ebee3e5

[MIG] Rename manifest files

b0a3638

Add beautier pages for unsubscription process.

5617ff8

[8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscri…

f1aa990

…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.

OCA Transbot updated translations from Transifex

4d8398b

[MIG][mass_mailing_custom_unsubscribe] Migrate to v10

7e3310d

OCA Transbot updated translations from Transifex

7dfd7db

chienandalu force-pushed the 11.0-mig-mass_mailing_custom_unsubscribe branch from 578c624 to 6e64405 Compare June 11, 2018 16:44

chienandalu force-pushed the 11.0-mig-mass_mailing_custom_unsubscribe branch from f5a749a to 358b0e4 Compare June 12, 2018 12:39

yajo requested changes Jun 12, 2018

View reviewed changes

rafaelbn added needs review and removed work in progress labels Jun 12, 2018

[MIG] mass_mailing_custom_unsubscribe: Migration to 11.0

41c5f6d

chienandalu force-pushed the 11.0-mig-mass_mailing_custom_unsubscribe branch from 358b0e4 to 41c5f6d Compare June 12, 2018 15:41

yajo approved these changes Jun 13, 2018

View reviewed changes

pedrobaeza approved these changes Jun 13, 2018

View reviewed changes

pedrobaeza merged commit 9815862 into OCA:11.0 Jun 13, 2018

pedrobaeza deleted the 11.0-mig-mass_mailing_custom_unsubscribe branch June 13, 2018 08:23

pedrobaeza mentioned this pull request Jun 13, 2018

Migration to version 11.0 #203

Closed

26 tasks

SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024

Merge pull request OCA#279 from OCA/12.0

f078056

Syncing from upstream OCA/social (12.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP][MIG] mass_mailing_custom_unsubscribe: Migration to 11.0 #279

[WIP][MIG] mass_mailing_custom_unsubscribe: Migration to 11.0 #279

chienandalu commented May 25, 2018 •

edited

Loading

yajo commented May 28, 2018

chienandalu commented May 28, 2018

chienandalu commented May 29, 2018

rafaelbn commented Jun 1, 2018 •

edited

Loading

yajo Jun 4, 2018

yajo Jun 4, 2018

yajo Jun 4, 2018

yajo Jun 4, 2018

yajo Jun 4, 2018

yajo Jun 4, 2018

yajo Jun 4, 2018

pedrobaeza commented Jun 12, 2018

yajo left a comment

yajo Jun 12, 2018

yajo Jun 12, 2018

yajo Jun 12, 2018

rafaelbn commented Jun 12, 2018

yajo commented Jun 12, 2018

chienandalu commented Jun 12, 2018

rafaelbn commented Jun 12, 2018

chienandalu commented Jun 12, 2018

yajo left a comment

[WIP][MIG] mass_mailing_custom_unsubscribe: Migration to 11.0 #279

[WIP][MIG] mass_mailing_custom_unsubscribe: Migration to 11.0 #279

Conversation

chienandalu commented May 25, 2018 • edited Loading

yajo commented May 28, 2018

chienandalu commented May 28, 2018

chienandalu commented May 29, 2018

rafaelbn commented Jun 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jun 12, 2018

yajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn commented Jun 12, 2018

yajo commented Jun 12, 2018

chienandalu commented Jun 12, 2018

rafaelbn commented Jun 12, 2018

chienandalu commented Jun 12, 2018

yajo left a comment

Choose a reason for hiding this comment

chienandalu commented May 25, 2018 •

edited

Loading

rafaelbn commented Jun 1, 2018 •

edited

Loading