Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][17.0] tms_sale #134

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[ADD][17.0] tms_sale #134

merged 1 commit into from
Oct 25, 2024

Conversation

EdgarRetes
Copy link

@EdgarRetes EdgarRetes commented Jul 25, 2024 •
edited by max3903
Loading

@max3903 please check this?

Dependencies:

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Jul 25, 2024 •
edited
Loading

The idea of generating a TMS order for a sales order of transportation services or for each item in the sales order is interesting. However, how would we handle a case where, in the same trip, we could have more than one sale order? Or would we have another model that aggregates the TMS orders to compose, for example, the load of a truck?

cc @douglascstd @max3903

@max3903 max3903 added this to the 17.0 milestone Jul 29, 2024
@max3903 max3903 self-assigned this Jul 29, 2024
@max3903
Copy link
Member

max3903 commented Jul 29, 2024

@marcelsavegnago A TMS order would belong to one and only one sales order. Otherwise it becomes complicated to determine who you charge and for what...

@max3903 max3903 mentioned this pull request Jul 31, 2024
Open
16 tasks
@EdgarRetes EdgarRetes closed this Sep 18, 2024
@EdgarRetes EdgarRetes reopened this Sep 18, 2024
@EdgarRetes EdgarRetes closed this Sep 18, 2024
@EdgarRetes EdgarRetes reopened this Sep 18, 2024
@max3903
Copy link
Member

max3903 commented Oct 12, 2024

@EdgarRetes Can you rebase?

@max3903 max3903 mentioned this pull request Oct 12, 2024
Merged
3 tasks
@max3903 max3903 changed the title [ADD][17.0] tms sale [ADD][17.0] tms_sale Oct 12, 2024
@EdgarRetes EdgarRetes force-pushed the 17.0_tms_sale branch 2 times, most recently from 3987af3 to b30ae9d Compare October 18, 2024 22:41
@EdgarRetes
Copy link
Author

EdgarRetes commented Oct 18, 2024 •
edited
Loading

@max3903 Ticket sale is completed

@EdgarRetes
Copy link
Author

@max3903 can you check this please?

@max3903
Copy link
Member

max3903 commented Oct 25, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-134-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c1eb05e into OCA:17.0 Oct 25, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad7ce96. Thanks a lot for contributing to OCA. ❤️

@max3903 max3903 deleted the 17.0_tms_sale branch October 25, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels
enhancement merged 🎉 needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EdgarRetes @marcelsavegnago @max3903 @OCA-git-bot