Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stock_available should not ignores reserved quants afer all #79

Closed
clonedagain opened this issue Sep 8, 2015 · 0 comments
Closed

stock_available should not ignores reserved quants afer all #79

clonedagain opened this issue Sep 8, 2015 · 0 comments

Comments

@clonedagain
Copy link

It had escaped my attention but during the migration of stock_available, @gfcapalbo slightly changed the semantics : instead of basing computations on the virtual stock (= sum of quants - sum of future moves), we now use the sum of quants where reservation_id is False.

Now I doubt this is correct. For example, a quant could be reserved for an internal move, and we would still be able to promise it to customers.

clonedagain pushed a commit to numerigraphe/stock-logistics-warehouse that referenced this issue Sep 8, 2015
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79
cyrilgdn pushed a commit to cyrilgdn/stock-logistics-warehouse that referenced this issue Mar 21, 2016
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79
kikopeiro pushed a commit to kikopeiro/stock-logistics-warehouse that referenced this issue Nov 14, 2017
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79
devang-dreambits pushed a commit to devang-dreambits/stock-logistics-warehouse that referenced this issue Feb 7, 2019
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
sergio-teruel pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this issue Jun 26, 2019
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
pedrobaeza pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this issue Jul 5, 2019
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
ps-tubtim pushed a commit to ecosoft-odoo/stock-logistics-warehouse that referenced this issue Dec 19, 2019
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
ps-tubtim pushed a commit to ecosoft-odoo/stock-logistics-warehouse that referenced this issue Jun 16, 2020
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
HviorForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this issue Sep 2, 2020
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
florian-dacosta pushed a commit to akretion/stock-logistics-warehouse that referenced this issue Dec 24, 2020
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
ThomasBinsfeld pushed a commit to acsone/stock-logistics-warehouse that referenced this issue Mar 23, 2021
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
ThomasBinsfeld pushed a commit to acsone/stock-logistics-warehouse that referenced this issue Mar 23, 2021
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
ThomasBinsfeld pushed a commit to acsone/stock-logistics-warehouse that referenced this issue Mar 23, 2021
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this issue Aug 16, 2021
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
JasminSForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this issue Jan 21, 2022
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
marielejeune pushed a commit to acsone/stock-logistics-warehouse that referenced this issue Sep 16, 2022
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
marielejeune pushed a commit to acsone/stock-logistics-warehouse that referenced this issue Oct 4, 2022
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
marielejeune pushed a commit to acsone/stock-logistics-availability that referenced this issue Oct 7, 2022
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA/stock-logistics-warehouse#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA/stock-logistics-warehouse#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
glitchov pushed a commit to acsone/stock-logistics-warehouse that referenced this issue Jan 17, 2023
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
gschrott-osi pushed a commit to ursais/stock-logistics-warehouse that referenced this issue Jun 5, 2023
[MIG] oak_helpdesk & oak_helpdesk_incident
AlexPForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this issue Aug 8, 2023
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
yannoliv pushed a commit to GumbysBE/stock-logistics-availability that referenced this issue Mar 28, 2024
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA/stock-logistics-warehouse#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA/stock-logistics-warehouse#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
bizzappdev pushed a commit to BizzAppDev-Systems/stock-logistics-availability that referenced this issue Apr 25, 2024
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA/stock-logistics-warehouse#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA/stock-logistics-warehouse#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
LuisBrose pushed a commit to LuisBrose/stock-logistics-availability that referenced this issue Dec 5, 2024
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA/stock-logistics-warehouse#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA/stock-logistics-warehouse#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
LuisBrose pushed a commit to LuisBrose/stock-logistics-availability that referenced this issue Dec 5, 2024
Commit 6c16913 changed the way we compute the immediately_usable_qty: instead of using the virtual stock, we used the sum of quants without reservations. But a quant may actually be reserved and still be available (for example it may be reserved for an internal move).
Fixes OCA/stock-logistics-warehouse#79

Remove loop and use correct decorator

Restore the features of stock_available_immediately

The previous fix restored stock_available but then there was no way to exclude the incomming moves from the count. This belongs in stock_available_immediately, restoring it cleanly.
This commit also takes care to respect the distinction between templates and variants, so it should fix OCA/stock-logistics-warehouse#73 too.

Restore the qty avail. to promise on variant treeview

PEP8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant