[MIG] stock_reserve 15.0 #1485

flachica · 2022-09-15T10:24:45Z

No description provided.

oca-clabot · 2022-09-28T13:39:21Z

Hey @flachica, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Andrius Preimantas andrius@versada.lt (no github login found)
Alexandre MOREAU alexandre.moreau@syleam.fr (no github login found)
Ismael Calvo ismael.calvo@factorlibre.com (no github login found)

Appreciation of efforts,
OCA CLAbot

victoralmau · 2022-09-28T13:54:07Z

Thank you for your work.
There is something wrong with this migration, the stock_reserve_sale addon is added and it should not.

Maybe it would be a good idea to finish the migration to v14 (#1346) and then continue with this one.

flachica · 2022-09-28T14:05:22Z

Sorry @victoralmau, this module is migrated in #1486. I got confused with branch

rousseldenis · 2022-10-07T07:52:20Z

/ocabot migration stock_reserve

rousseldenis · 2022-10-07T07:53:20Z

@flachica Could you remove unrelated files (stock_reserve_sale) ?

flachica · 2022-10-07T08:26:23Z

@flachica Could you remove unrelated files (stock_reserve_sale) ?

@rousseldenis In this PR I got confused about the branch but I thought I had solved it. Please, can you tell me where you see the remaining files? I can not find it

rousseldenis · 2022-10-07T08:47:21Z

@flachica Could you remove unrelated files (stock_reserve_sale) ?

@rousseldenis In this PR I got confused about the branch but I thought I had solved it. Please, can you tell me where you see the remaining files? I can not find it

No, it's ok, wrong browser tab 😓

stock_reserve/model/stock_reserve.py

stock_reserve/model/product.py

stock_reserve/tests/test_stock_reserve.py

…will serve as a basis for the sale pre-book

don't use half the quantity so that the reserved qty is different from available qty

For weird reasons, force-assigning a move does not associate quants. action_assign'ing the picking does, and is the same procedure that you can do via the interface.

[UPG] Upgraded to version 8, fixed references to new 8.0 views and moved fields that were in product.product to product.template [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [UPG] stock available immediately, corrected the calculation method of immediately_usable_qty to take in accountthe sign change in outgoing_qty (from negative to positive) in version 8. [FLAKE8] [FIX] renaming of a class, comment removing, useless code. [UPD] move out from unported to 8 for update [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [FIX] renaming of a class, comment removing, useless code. [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [UPD] move out from unported to 8 for update [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [FIX] renaming of a class, comment removing, useless code. [UPD] move out from unported to 8 for update [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [FIX] renaming of a class, comment removing, useless code. [UPD] move out from unported to 8 for update [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [FIX] renaming of a class, comment removing, useless code. [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [UPD] move out from unported to 8 for update [fix] remove duplicate view and correct view name [UPG][FIX] added outgoing field XML, that was in the base stock field in 7.0. [FIX] renaming of a class, comment removing, useless code.

before running the tests. This fixes the failure experienced when running the test in --init mode rather than --update mode.

flachica · 2022-10-27T06:30:15Z

@victoralmau How I can set this commit as coauthored with you? You are made a lot of valueable suggestions

- Additionally include note field in stock reservation. It [was](odoo/odoo@71203e0) removed

rousseldenis · 2022-10-27T06:52:15Z

@victoralmau How I can set this commit as coauthored with you? You are made a lot of valueable suggestions

You can use git cherry-pick to do so. Or oca-port tool https://pypi.org/project/oca-port/

victoralmau

Code review OK.

IMO, you don't need to add me as a co-author.

CasVissers-360ERP · 2022-11-29T13:41:15Z

@rousseldenis Think this one should be ready to merge?

rousseldenis

Code review

rousseldenis · 2022-11-29T14:15:48Z

/ocabot merge patch

OCA-git-bot · 2022-11-29T14:15:56Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1485-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2022-11-29T14:26:51Z

Congratulations, your PR was merged at 531e272. Thanks a lot for contributing to OCA. ❤️

flachica force-pushed the 15.0-mig-stock_reserve branch from 6cba807 to 4655bd0 Compare September 15, 2022 10:30

flachica mentioned this pull request Sep 15, 2022

Migration to version 15.0 #1278

Open

80 tasks

flachica force-pushed the 15.0-mig-stock_reserve branch 2 times, most recently from 624efd4 to 303302a Compare September 15, 2022 10:54

flachica force-pushed the 15.0-mig-stock_reserve branch from 303302a to daf80b8 Compare September 28, 2022 13:39

flachica force-pushed the 15.0-mig-stock_reserve branch from daf80b8 to 063ee5a Compare September 28, 2022 13:42

flachica force-pushed the 15.0-mig-stock_reserve branch from 063ee5a to 554f838 Compare September 28, 2022 14:02

OCA-git-bot added this to the 15.0 milestone Oct 7, 2022

rousseldenis added needs review migration labels Oct 7, 2022

rousseldenis added the needs fixing label Oct 7, 2022

rousseldenis removed the needs fixing label Oct 11, 2022

flachica mentioned this pull request Oct 11, 2022

[MIG] stock_reserve_sale 15.0 #1486

Closed

victoralmau suggested changes Oct 24, 2022

View reviewed changes

guewen and others added 9 commits October 27, 2022 08:28

[ADD] started a generic stock reservation module (stock_reserve), it …

cdace1f

…will serve as a basis for the sale pre-book

mark unported module as uninstallable

20bae06

reactivate module stock_reserve

8411366

fix flake8 warnings

eb3d861

update test

3371709

don't use half the quantity so that the reserved qty is different from available qty

fix button to open related move

e08c0a1

the reservation should reserve a quant

5f6089c

For weird reasons, force-assigning a move does not associate quants. action_assign'ing the picking does, and is the same procedure that you can do via the interface.

[ADD] removed view

5186747

gurneyalex and others added 12 commits October 27, 2022 08:28

force recomputation of stock.location hierachy

90fffd0

before running the tests. This fixes the failure experienced when running the test in --init mode rather than --update mode.

OCA Transbot updated translations from Transifex

ffefec7

[UPD] prefix versions with 8.0

17be489

[MIG] Make modules uninstallable

25bbd60

[FIX] remove en.po that was erroneously created by transbot

bf4fb18

[MIG] Rename manifest files

c153bd6

stock_reserve: migration to 10.0

e936ebc

remove obsolete .pot files [ci skip]

bf72d65

[IMP] stock_reserve: black, isort, prettier

4ff3ef4

[MIG] stock_reserve: Migration to v13.0

a38687e

[UPD] README.rst

e8ddc0b

[FIX+IMP] Update dotfiles + switch to GH actions

891e7c0

flachica force-pushed the 15.0-mig-stock_reserve branch from 21fca09 to 53a1945 Compare October 27, 2022 06:28

flachica force-pushed the 15.0-mig-stock_reserve branch from 53a1945 to 8c1ebc2 Compare October 27, 2022 06:32

flachica added 2 commits October 27, 2022 08:39

[IMP] stock_reserve: black, isort

1a8e6fc

[MIG] stock_reserve 15.0:

2261a8b

- Additionally include note field in stock reservation. It [was](odoo/odoo@71203e0) removed

flachica force-pushed the 15.0-mig-stock_reserve branch from 8c1ebc2 to 2261a8b Compare October 27, 2022 06:40

victoralmau approved these changes Oct 27, 2022

View reviewed changes

rousseldenis approved these changes Nov 29, 2022

View reviewed changes

OCA-git-bot added the approved label Nov 29, 2022

OCA-git-bot added the bot is merging ⏳ label Nov 29, 2022

OCA-git-bot merged commit 1cbe2ee into OCA:15.0 Nov 29, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] stock_reserve 15.0 #1485

[MIG] stock_reserve 15.0 #1485

flachica commented Sep 15, 2022

oca-clabot commented Sep 28, 2022

victoralmau commented Sep 28, 2022

flachica commented Sep 28, 2022

rousseldenis commented Oct 7, 2022

rousseldenis commented Oct 7, 2022

flachica commented Oct 7, 2022

rousseldenis commented Oct 7, 2022

flachica commented Oct 27, 2022

rousseldenis commented Oct 27, 2022 •

edited

Loading

victoralmau left a comment

CasVissers-360ERP commented Nov 29, 2022

rousseldenis left a comment

rousseldenis commented Nov 29, 2022

OCA-git-bot commented Nov 29, 2022

OCA-git-bot commented Nov 29, 2022

[MIG] stock_reserve 15.0 #1485

[MIG] stock_reserve 15.0 #1485

Conversation

flachica commented Sep 15, 2022

oca-clabot commented Sep 28, 2022

victoralmau commented Sep 28, 2022

flachica commented Sep 28, 2022

rousseldenis commented Oct 7, 2022

rousseldenis commented Oct 7, 2022

flachica commented Oct 7, 2022

rousseldenis commented Oct 7, 2022

flachica commented Oct 27, 2022

rousseldenis commented Oct 27, 2022 • edited Loading

victoralmau left a comment

Choose a reason for hiding this comment

CasVissers-360ERP commented Nov 29, 2022

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis commented Nov 29, 2022

OCA-git-bot commented Nov 29, 2022

OCA-git-bot commented Nov 29, 2022

rousseldenis commented Oct 27, 2022 •

edited

Loading