[15.0][MIG] stock_request_analytic #1587

ps-tubtim · 2022-12-22T07:31:51Z

Standard Migration.

Wating for:

[15.0][MIG] stock_analytic: migration account-analytic#448

rousseldenis · 2022-12-22T07:38:27Z

@ps-tubtim Thanks for this. FYI, you can follow this guide if you want this PR being tested by github and allowing runboat to be launched : https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

rousseldenis · 2022-12-22T07:38:41Z

/ocabot migration stock_request_analytic

rousseldenis · 2022-12-22T07:44:06Z

@ps-tubtim Please pay attention to put version change in migration commit, not in pre-commit stuff one. Thanks

ps-tubtim · 2022-12-22T08:10:03Z

@ps-tubtim Please pay attention to put version change in migration commit, not in pre-commit stuff one. Thanks

Ok, I changed it.

rousseldenis · 2023-02-16T07:59:23Z

oca_dependencies.txt

@@ -0,0 +1 @@
+account-analytic


This is not needed anymore.

If this depends on another pull request, the good method is this one: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Either, the addon in account analytic will be found by pip automatically

Thank you. I deleted this file.

stock_request_analytic/models/stock_request.py

stock_request_analytic/models/stock_rule.py

stock_request_analytic/tests/test_stock_request_analytic.py

* clean views. * allow to create a stock.request with no analytic account. * remove copy attribute in non-stored field. * remove non-existing field from compute method.

…rrors

Currently translated at 100.0% (8 of 8 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_analytic/zh_CN/

Currently translated at 100.0% (8 of 8 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_analytic/pt_BR/

TT28488

Co-authored-by: Pimolnat Suntian <pimolnats@ecosoft.co.th> TT28896

Currently translated at 100.0% (9 of 9 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_analytic Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_analytic/pt_BR/

ps-tubtim · 2023-02-23T03:45:55Z

@rousseldenis I already updated my code. Could you review it again?

rousseldenis · 2023-02-23T07:44:56Z

stock_request_analytic/models/stock_request.py

-        if self.order_id and self.order_id.default_analytic_account_id:
-            self.analytic_account_id = self.order_id.default_analytic_account_id
-        return res
+        for req in self.sudo():


@ps-tubtim Have you try to add 'compute_sudo=True' on field directly ?

@rousseldenis I already added compute_sudo=True on field. Please review it again.

Saran440

Functional Test 👍

rousseldenis

Code review

OCA-git-bot · 2023-03-20T09:47:35Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2023-03-20T09:57:47Z

/ocabot merge patch

OCA-git-bot · 2023-03-20T09:58:24Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1587-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2023-03-20T10:23:50Z

Congratulations, your PR was merged at 2d66ab4. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 15.0 milestone Dec 22, 2022

rousseldenis added needs review migration labels Dec 22, 2022

OCA-git-bot mentioned this pull request Dec 22, 2022

Migration to version 15.0 #1278

Open

80 tasks

ps-tubtim force-pushed the 15.0-mig-stock_request_analytic branch from 9814b29 to 0638e56 Compare December 22, 2022 08:03

ps-tubtim force-pushed the 15.0-mig-stock_request_analytic branch from 0638e56 to f916822 Compare January 30, 2023 18:05

ps-tubtim force-pushed the 15.0-mig-stock_request_analytic branch from f916822 to bc0d595 Compare February 16, 2023 04:43

rousseldenis reviewed Feb 16, 2023

View reviewed changes

ps-tubtim force-pushed the 15.0-mig-stock_request_analytic branch from bc0d595 to 6bd3af5 Compare February 17, 2023 02:13

rousseldenis requested changes Feb 17, 2023

View reviewed changes

stock_request_analytic/models/stock_request.py Outdated Show resolved Hide resolved

stock_request_analytic/models/stock_rule.py Outdated Show resolved Hide resolved

stock_request_analytic/tests/test_stock_request_analytic.py Outdated Show resolved Hide resolved

AaronHForgeFlow and others added 16 commits February 22, 2023 18:02

[ADD]stock_request_analytic

8b84c40

[11.0] stock_request_analytic:

4ae5a9d

* clean views. * allow to create a stock.request with no analytic account. * remove copy attribute in non-stored field. * remove non-existing field from compute method.

[12.0][MIG] stock_request_analytic

8318e00

[IMP] Simplify inheritance of states

9d5d061

[FIX] stock_request_*: add expected_date implicit on tests to avoid e…

68e59a0

…rrors

Added translation using Weblate (Chinese (Simplified))

6218238

Added translation using Weblate (Portuguese (Brazil))

7a3ea1f

[IMP] stock_request_analytic: add analytic tags to Stock Requests

0204593

TT28488

[IMP] stock_request_analytic: black, isort, prettier

28f8601

[MIG] stock_request_analytic: Migration to 13.0

1362c48

Co-authored-by: Pimolnat Suntian <pimolnats@ecosoft.co.th> TT28896

[UPD] Update stock_request_analytic.pot

d4705e2

[UPD] README.rst

4e96e1a

[IMP] stock_request_analytic: black, isort, prettier

3bb29c2

[14.0][MIG] stock_request_analytic

35c89f4

oca-travis and others added 10 commits February 22, 2023 18:02

[UPD] Update stock_request_analytic.pot

bf857d9

[UPD] README.rst

6f784b3

stock_request_analytic 14.0.1.0.1

e06a24e

[FIX] Fix access right issues when using actions

566c62a

stock_request_analytic 14.0.1.0.2

a738b94

[FIX] Licensing issues

91c10df

[UPD] README.rst

be34189

stock_request_analytic 14.0.1.0.3

700bee0

[IMP] stock_request_analytic: black, isort, prettier

be42401

ps-tubtim force-pushed the 15.0-mig-stock_request_analytic branch 3 times, most recently from dd1b865 to ba32949 Compare February 23, 2023 03:40

rousseldenis reviewed Feb 23, 2023

View reviewed changes

[MIG] stock_request_analytic: Migration to 15.0

bd7b4c9

ps-tubtim force-pushed the 15.0-mig-stock_request_analytic branch from ba32949 to bd7b4c9 Compare February 27, 2023 03:50

Saran440 approved these changes Mar 15, 2023

View reviewed changes

rousseldenis approved these changes Mar 20, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 20, 2023

OCA-git-bot added the bot is merging ⏳ label Mar 20, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 20, 2023

OCA-git-bot closed this Mar 20, 2023

OCA-git-bot merged commit bd2b839 into OCA:15.0 Mar 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] stock_request_analytic #1587

[15.0][MIG] stock_request_analytic #1587

ps-tubtim commented Dec 22, 2022 •

edited

Loading

rousseldenis commented Dec 22, 2022

rousseldenis commented Dec 22, 2022

rousseldenis commented Dec 22, 2022

ps-tubtim commented Dec 22, 2022

rousseldenis Feb 16, 2023

ps-tubtim Feb 17, 2023

ps-tubtim commented Feb 23, 2023

rousseldenis Feb 23, 2023

ps-tubtim Feb 27, 2023

Saran440 left a comment

rousseldenis left a comment

OCA-git-bot commented Mar 20, 2023

rousseldenis commented Mar 20, 2023

OCA-git-bot commented Mar 20, 2023

OCA-git-bot commented Mar 20, 2023

		@@ -0,0 +1 @@
		account-analytic

[15.0][MIG] stock_request_analytic #1587

[15.0][MIG] stock_request_analytic #1587

Conversation

ps-tubtim commented Dec 22, 2022 • edited Loading

rousseldenis commented Dec 22, 2022

rousseldenis commented Dec 22, 2022

rousseldenis commented Dec 22, 2022

ps-tubtim commented Dec 22, 2022

rousseldenis Feb 16, 2023

Choose a reason for hiding this comment

ps-tubtim Feb 17, 2023

Choose a reason for hiding this comment

ps-tubtim commented Feb 23, 2023

rousseldenis Feb 23, 2023

Choose a reason for hiding this comment

ps-tubtim Feb 27, 2023

Choose a reason for hiding this comment

Saran440 left a comment

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 20, 2023

rousseldenis commented Mar 20, 2023

OCA-git-bot commented Mar 20, 2023

OCA-git-bot commented Mar 20, 2023

ps-tubtim commented Dec 22, 2022 •

edited

Loading