[15.0][MIG] stock_request_tier_validation #1595

ps-tubtim · 2022-12-27T10:54:40Z

Standard migration, set manual view = False

ps-tubtim · 2022-12-27T10:55:18Z

/ocabot migration stock_request_tier_validation

github-actions · 2023-06-18T12:26:17Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Saran440

Code Review 👍

OriolMForgeFlow

Some small comments.

Functional review: works properly 👍🏼

OriolMForgeFlow · 2023-08-21T07:02:41Z

stock_request_tier_validation/views/stock_request_order_view.xml

+<odoo>
+    <record id="view_stock_request_order_filter" model="ir.ui.view">
+        <field name="name">stock.request.select - stock_request_tier_validation</field>
+        <field name="model">stock.request</field>
+        <field name="inherit_id" ref="stock_request.stock_request_search" />
+        <field name="arch" type="xml">
+            <search position="inside">
+                <group expand="0" string="Need actions">
+                    <filter
+                        name="needs_review"
+                        string="Needs my Review"
+                        domain="[('reviewer_ids','in',uid), ('state', 'not in', ['done', 'cancel'])]"
+                        help="My Stock Request Orders to review"
+                    />
+                    <filter
+                        name="tier_validated"
+                        string="Validated"
+                        domain="[('validated', '=', True)]"
+                        help="Stock Requests validated and ready to be confirmed"
+                    />
+                </group>
+            </search>
+        </field>
+    </record>
+</odoo>


This view should be used in the stock request order model. In Runboat, I can only see two duplicated filters for the stock request model, and there are no filters available for the stock request order model. I am referring to the Needs My Review and Validated filters.

OriolMForgeFlow · 2023-08-21T07:07:00Z

stock_request_tier_validation/tests/test_stock_request_tier_validation.py

+    def setUp(self):
+        super(TestStockRequest, self).setUp()


I think you should change the setUp method to setUpClass according to the Migration Rules to v15.

Currently translated at 94.1% (16 of 17 strings) Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_request_tier_validation/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_request_tier_validation/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_tier_validation/

Currently translated at 100.0% (19 of 19 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_request_tier_validation/zh_CN/

Currently translated at 100.0% (19 of 19 strings) Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_tier_validation/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_request_tier_validation/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_request_tier_validation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_request_tier_validation/

Saran440 · 2023-09-14T06:59:04Z

@OriolMForgeFlow Thank you for your review. I fixed it.

rousseldenis

Code review

rousseldenis · 2023-09-14T07:30:32Z

@OriolMForgeFlow Could you update your review ?

OCA-git-bot · 2023-09-14T07:37:24Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OriolMForgeFlow

LGTM!

rousseldenis · 2023-09-14T08:27:26Z

/ocabot merge nobump

OCA-git-bot · 2023-09-14T08:27:36Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1595-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2023-09-14T08:39:19Z

Congratulations, your PR was merged at c6f9c52. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added this to the 15.0 milestone Dec 27, 2022

OCA-git-bot mentioned this pull request Dec 27, 2022

Migration to version 15.0 #1278

Open

80 tasks

ps-tubtim force-pushed the 15.0-mig-stock_request_tier_validation branch from 1abbe4a to dd17ae0 Compare December 27, 2022 11:00

ps-tubtim added the migration label Dec 27, 2022

ps-tubtim force-pushed the 15.0-mig-stock_request_tier_validation branch from dd17ae0 to 991cbdc Compare February 16, 2023 04:36

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 18, 2023

github-actions bot closed this Jul 23, 2023

ps-tubtim reopened this Aug 11, 2023

Saran440 force-pushed the 15.0-mig-stock_request_tier_validation branch from d3d0bba to 930e879 Compare August 11, 2023 07:40

Saran440 approved these changes Aug 11, 2023

View reviewed changes

OriolMForgeFlow reviewed Aug 21, 2023

View reviewed changes

HviorForgeFlow and others added 17 commits September 14, 2023 13:58

[11.0][ADD] stock_request_tier_validation (OCA#528)

b84c97b

[UPD] README.rst

102ecf6

[UPD] Update stock_request_tier_validation.pot

5961f6e

[11.0][FIX] stock_request_tier_validation: update tier definitions

368b5bc

[UPD] Update stock_request_tier_validation.pot

2fb5ea2

Added translation using Weblate (Spanish)

c1535d0

[11.0][FIX] stock_request_tier_validation: small typos and missing name.

846595b

[UPD] Update stock_request_tier_validation.pot

9c15bc5

[UPD] Update stock_request_tier_validation.pot

272e71b

[12.0][MIG] stock_request_tier_validation

b4ae11e

[UPD] Update stock_request_tier_validation.pot

7a465a1

[12.0][FIX] stock_request_tier_validation

c79c7d5

stock_request_tier_validation 12.0.1.1.0

4bc650b

[UPD] README.rst

63e5dae

liweijie0812 and others added 15 commits September 14, 2023 13:58

[12.0][FIX] stock_request_tier_validation: SRO tier validation reviews

88e2c30

[IMP] stock_request_tier_validation: black, isort

753a9dd

[MIG] stock_request_tier_validation: Migration to 13.0

1747d66

[UPD] Update stock_request_tier_validation.pot

607fc68

[UPD] Eficent -> ForgeFlow

6ac72ca

[MIG] stock_request_tier_validation: Migration to 14.0

2da8ac7

[UPD] Update stock_request_tier_validation.pot

367a983

[UPD] README.rst

dc58566

[UPD] Update stock_request_tier_validation.pot

604a7f1

[IMP] stock_request_tier_validation: black, isort, prettier

0fee55c

[MIG] stock_request_tier_validation: Migration to 15.0

502f96c

Saran440 force-pushed the 15.0-mig-stock_request_tier_validation branch from 3a0cb33 to 502f96c Compare September 14, 2023 06:59

rousseldenis approved these changes Sep 14, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 14, 2023

OCA-git-bot added the ready to merge label Sep 14, 2023

OriolMForgeFlow approved these changes Sep 14, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Sep 14, 2023

OCA-git-bot merged commit 4b4ea95 into OCA:15.0 Sep 14, 2023
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] stock_request_tier_validation #1595

[15.0][MIG] stock_request_tier_validation #1595

ps-tubtim commented Dec 27, 2022

ps-tubtim commented Dec 27, 2022

github-actions bot commented Jun 18, 2023

Saran440 left a comment

OriolMForgeFlow left a comment

OriolMForgeFlow Aug 21, 2023 •

edited

Loading

OriolMForgeFlow Aug 21, 2023

Saran440 commented Sep 14, 2023

rousseldenis left a comment

rousseldenis commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

OriolMForgeFlow left a comment

rousseldenis commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

[15.0][MIG] stock_request_tier_validation #1595

[15.0][MIG] stock_request_tier_validation #1595

Conversation

ps-tubtim commented Dec 27, 2022

ps-tubtim commented Dec 27, 2022

github-actions bot commented Jun 18, 2023

Saran440 left a comment

Choose a reason for hiding this comment

OriolMForgeFlow left a comment

Choose a reason for hiding this comment

OriolMForgeFlow Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

OriolMForgeFlow Aug 21, 2023

Choose a reason for hiding this comment

Saran440 commented Sep 14, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

OriolMForgeFlow left a comment

Choose a reason for hiding this comment

rousseldenis commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

OriolMForgeFlow Aug 21, 2023 •

edited

Loading