Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] stock_picking_auto_revert #1918

Closed

Conversation

AaronHForgeFlow
Copy link
Contributor

Module to correct mistakes in pickings the fast way. Instead of cancel this module will create a return and then will recreate the issued picking.

Based on OCA/stock-logistics-workflow#593 Originally it was discarded because of the stock_cancel module.

cc @ForgeFlow

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_auto_revert

@rousseldenis
Copy link
Contributor

@AaronHForgeFlow Why having put here and not in workflow repo ? Could you explain the difference with stock_cancel module ?

@AaronHForgeFlow
Copy link
Contributor Author

I am not sure what is the difference between the two repos. It was proposed here because this module was proposed to this repo in v10. But I don't mind to move it.

Stock_cancel module allowed to cancel done pickings, by removing the stock move from the quant history and change the location of the quant: https://github.com/OCA/stock-logistics-workflow/blob/10.0/stock_cancel/models/stock_quant.py It was used to correct mistakes when validating pickings. However, there were challenges like covering the case where the product is not anymore in the destination location. Moreover, after the introduction of stock.valuation.layers it was almost impossible to migrate that module with consistency. At the end we followed a similar approach Odoo uses for correcting mistakes in invoices. that is, do a reverse and recreate the original invoice in draft state so the user can edit it.

@rousseldenis
Copy link
Contributor

t was proposed here because this module was proposed to this repo in v10.

It seems not 😅 OCA/stock-logistics-workflow#593

At the end we followed a similar approach Odoo uses for correcting mistakes in invoices. that is, do a reverse and recreate the original invoice in draft state so the user can edit it.

Great

@AaronHForgeFlow
Copy link
Contributor Author

It seems not 😅 OCA/stock-logistics-workflow#593

🤣

Closed in favor of OCA/stock-logistics-workflow#1491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants