-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] stock_warehouse_calendar: Migration to 17.0 #1933
[17.0][MIG] stock_warehouse_calendar: Migration to 17.0 #1933
Conversation
the method `wh_plan_days` can be used in any place where planning or scheduling needs to be done in a given warehouse context, considering the working days if set.
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_warehouse_calendar Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_warehouse_calendar/zh_CN/
when delta argument is a float `plan_days` method can return unexpected False result. This can lead to silent errors. Therefore we ensure that delta is a integer in the helper.
Currently translated at 16.6% (1 of 6 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_warehouse_calendar Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_warehouse_calendar/it/
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_warehouse_calendar Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_warehouse_calendar/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_warehouse_calendar Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_warehouse_calendar/
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_warehouse_calendar Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_warehouse_calendar/es/
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_warehouse_calendar Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_warehouse_calendar/it/
/ocabot migration stock_warehouse_calendar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
from odoo.tests.common import TransactionCase | ||
|
||
|
||
class TestStockWarehouseCalendar(TransactionCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, Odoo has since v16 a BaseCommon class which improves performances : https://github.com/odoo/odoo/blob/17.0/odoo/addons/base/tests/common.py#L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 2093266. Thanks a lot for contributing to OCA. ❤️ |
No description provided.