Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_warehouse_calendar: Migration to 17.0 #1933

Merged
merged 44 commits into from
Mar 18, 2024

Conversation

fredericgrall
Copy link

No description provided.

JordiBForgeFlow and others added 30 commits January 25, 2024 10:14
the method `wh_plan_days` can be used in any place where planning
or scheduling needs to be done in a given warehouse context,
considering the working days if set.
Currently translated at 100.0% (3 of 3 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_warehouse_calendar
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_warehouse_calendar/zh_CN/
when delta argument is a float `plan_days` method can return
unexpected False result. This can lead to silent errors.
Therefore we ensure that delta is a integer in the helper.
Currently translated at 16.6% (1 of 6 strings)

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_warehouse_calendar
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_warehouse_calendar/it/
jabelchi and others added 14 commits January 25, 2024 10:14
Currently translated at 100.0% (3 of 3 strings)

Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_warehouse_calendar
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_warehouse_calendar/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_warehouse_calendar
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_warehouse_calendar/
Currently translated at 100.0% (3 of 3 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_warehouse_calendar
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_warehouse_calendar/es/
Currently translated at 100.0% (3 of 3 strings)

Translation: stock-logistics-warehouse-16.0/stock-logistics-warehouse-16.0-stock_warehouse_calendar
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_warehouse_calendar/it/
@rousseldenis
Copy link
Contributor

/ocabot migration stock_warehouse_calendar

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

from odoo.tests.common import TransactionCase


class TestStockWarehouseCalendar(TransactionCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Odoo has since v16 a BaseCommon class which improves performances : https://github.com/odoo/odoo/blob/17.0/odoo/addons/base/tests/common.py#L21

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1933-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1538650 into OCA:17.0 Mar 18, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2093266. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.