Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] product_route_profile fix view #1939

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

bguillot
Copy link

@bguillot bguillot commented Feb 8, 2024

Hello ,

the route_ids field must be read-only in the view to avoid triggering the inverse method, which recalculates the route_profile_id field when the force_route_profile_id field is filled in.

@OCA-git-bot
Copy link
Contributor

Hi @Kev-Roche,
some modules you are maintaining are being modified, check this out!

@StefanRijnhart
Copy link
Member

Thanks! Can you amend your commit to something like

[FIX] product_route_profile: prevent triggering inverse method

Set route_ids as readonly to avoid triggering inverse method and changing
the route_profile_id when adding force_route_profile_id

(is how I'm cherrypicking this into the 17.0 migration at #2097)

@rousseldenis
Copy link
Contributor

@bguillot Could you attend @StefanRijnhart comments? Thanks

Set route_ids as readonly to avoid triggering inverse method and changing
the route_profile_id when adding force_route_profile_id
@bguillot bguillot force-pushed the 14-fix-route-profile-inverse branch from d506d7b to 042d190 Compare October 9, 2024 12:46
@bguillot
Copy link
Author

bguillot commented Oct 9, 2024

sorry, I missed the comments.

It's done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Kev-Roche
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1939-by-Kev-Roche-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b4b9ce4 into OCA:14.0 Oct 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 451baec. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants