Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_cycle_count #1995

Merged
merged 90 commits into from
Apr 24, 2024

Conversation

ArnauCForgeFlow
Copy link
Contributor

@ArnauCForgeFlow ArnauCForgeFlow commented Apr 16, 2024

Migration to 15.0

@rousseldenis
Copy link
Contributor

/ocabot migration stock_cycle_count

@rousseldenis
Copy link
Contributor

rousseldenis commented Apr 17, 2024

@ArnauCForgeFlow To help review, don't hesitate to put depending PR's links in this PR description.

Moreover, you can add it through : https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

In order to make tests running and be able to launch runboat

@LoisRForgeFlow
Copy link
Contributor

stock_inventory_exclude_sublocation is no longer a dependency after the change done in #1991

LoisRForgeFlow and others added 21 commits April 24, 2024 12:35
 * Update README.
 * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.
…tment related to a cycle count cannot be modified.
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 15.0-mig-stock_cycle_count branch 2 times, most recently from e9694d3 to 1f0c9ab Compare April 24, 2024 11:06
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a strict migration, I think this one is good to go.

After this, more improvements to come in #1997.

Copy link
Contributor

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review! LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

@ArnauCForgeFlow litte detail

Remove the duplicated Assigned to from views

image

@ArnauCForgeFlow
Copy link
Contributor Author

@LoisRForgeFlow Done! also removed company_id field since it is now declared in stock_inventory module.

@LoisRForgeFlow
Copy link
Contributor

Thanks!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1995-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 537b5d5 into OCA:15.0 Apr 24, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at baeb889. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-mig-stock_cycle_count branch April 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.