-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] [NEW] stock_orderpoint_manual_procurement #210
[8.0] [NEW] stock_orderpoint_manual_procurement #210
Conversation
Depends on merging #209 |
@jbeficent thanks for your contributions. Few questions:
|
@andhit-r The orderpoints min and max quantity become recommendations. The user can stick to them, or propose his own procurement. That's the beauty of it. You DON'T have to stick to what the reordering rule recommends in order to properly manage your warehouse. |
@jbeficent having a feature to change procure qty surely has it own benefit. I am 100% agree with that. But procurement rule are agreement between department (purchase, warehouse, finance). You can not change it easily. My propose alternatives is to restrict qty changes to specific group |
@andhit-r This module introduces the possibility to control WHEN and HOW MUCH to procure, and converts the reordering rules in recommendations to reorder. But the user has the last word on both parameters. If a company does not want to let users have this level of control, they should not install this module. Perhaps this does not make sense to you know from a business perspective. It is part of a bigger scheme that I'm putting in place to empower users to better plan and execute the logistics in order to reach the optimum stock levels. Give me a few days and you'll see other modules that go in this same direction. This module is, IMHO, formally correct, and has a valid business case. |
@jbeficent i also have a business case that require manual procurement, but the manual procurement has to respect procurement rule. That's why i suggest the additional group to change qty. If user belong to that group then the select qty table showed and if not than the select qty table is invisible. |
…ommended procure quantity when a manual procurement order is created.
@andhit-r I have incorporated your feedback comments regarding the group allowed to change the quantity. And I also added tests. |
@jbeficent thanks for the changes. 👍 |
cc @eficent |
@api.onchange('product_id') | ||
def onchange_product_id(self): | ||
for rec in self: | ||
rec.procure_uom_id = rec.product_id.uom_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an error when selecting the product in the procurement form: "TypeError: 'int' object is not iterable". May the cause of this error be here?
continue | ||
if float_compare(prods, op.product_min_qty, | ||
precision_rounding=op.product_uom.rounding) < 0: | ||
qty = max(op.product_min_qty, op.product_max_qty) - prods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a Reordering rule for the product [DVD] Blank DVD-RW with the following values:
Minimum Quantity 5.000
Maximum Quantity 25.000
Quantity Multiple 1.000
Unit of measure: Dozens
The quantity on hand is 0.00 and the forecasted quantity is 0.00 dozens.
When I create a procurement and I select the product and then the unit of measure, the quantity proposed is the maximum quantity in the reordering rule and the unit of measure is Dozens.
It works as expected, however why do we choose the maximum instead of the minimum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aheficent minimum qty is a trigger to let procurement engine start procuring. So if the stock level drop below minimum qty it will trigger procurement. Max qty will tell procurement engine how many will it procure. Here are few links regarding stock level:
https://www.lokad.com/min-max-inventory-planning-definition
http://accountlearning.blogspot.co.id/2010/05/minimum-level-or-safety-stock-and-its.html
@mikevhe18 @azmimr67 @m-sani would you kindly help review this PR. Many thanks. |
👍 |
1 similar comment
👍 |
Thanks all for your reviews! This is now merged. cc @lreficent can you port to v9? |
@jbeficent This module depends on stock_orderpoint_uom module, which is not available in v9. Might we migrate that one first? |
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
…reserve Revert PR OCA#123 - Dispatch optimisation is not V8 compatible
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
[ADD] stock_orderpoint_procure_uom
Stock Orderpoint Manual Procurement
This module allows users to manually start procurements from the list of
reordering rules, based on the quantity that is recommended to be procured.
Usage
Go to 'Configuration / Reordering Rules' and review the quantity recommended
to be procured. You can now start the procurement for a single or a list of
reordering rules.
The recommended quantity to procure is adjusted to the procurement unit of
measure indicated in the reordering rule.