[17.0][MIG] stock_secondary_unit: Migration to 17.0 #2121
Conversation
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
489e38d to
7e66877
Compare
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
7e66877 to
3ba5a7a
Compare
|
@rousseldenis Hey! I’d like to ask if there’s anything missing for it to be approved. Thanks in advance! Best regards! |
|
/ocabot migration stock_secondary_unit |
Reviews :-) |
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
2 times, most recently
from
4d546d3 to
0bb3672
Compare
|
Please include #2080 |
|
Sorry but I have seen that there are 2 other PRs for this migration, please indicate if this one overwrites them to be closed. |
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
2 times, most recently
from
318a76d to
a9ed261
Compare
|
@pilarvargas-tecnativa Hey! I just added it! |
|
@fredericgrall Hey! Would you mind closing your PR and reviewing this one when you have a moment? I’d really appreciate it. Thanks in advance! |
|
@pilarvargas-tecnativa Hi!! I would like to ask you if you can review this PR. |
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
a9ed261 to
984cec6
Compare
|
This PR has the |
|
@rousseldenis HI!! I would like to ask you if is something missing out? Regards |
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
a52533a to
960991e
Compare
I just corrected it |
I just added it |
Hi @rov-adhoc , The comment to which @juancarlosonate-tecnativa refers is the one about the xpath error: https://github.com/OCA/stock-logistics-warehouse/pull/2121/files#r1843723939 You have marked it as resolved but the error persists. With an incorrect xpath the fields are duplicated and are not visible in the mobile view, which was the purpose of the commit I mentioned when you removed this part of the code. When you add this code again, which has its purpose, you have to adapt it so that it can be seen correctly in mobile views.
This is v16 and is how it should look in mobile view:
|
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
960991e to
31d1b2b
Compare
Thank you for providing more details! Now I fully understand what you mean. I’ve made the necessary corrections, and I hope everything is in order now |
|
This PR has the |
There was a problem hiding this comment.
in the product form, the action_update_quantity_on_hand appears duplicated
31d1b2b#diff-0ed52cda6c2ce263d32165b3d1b7998595886c080423e3e66de63ff19b4a12f1
| ref="stock.product_template_form_view_procurement_button" | ||
| /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//button[@name='action_open_quants']" position="after"> | ||
| <xpath | ||
| expr="//button[@name='action_update_quantity_on_hand']" | ||
| position="after" | ||
| > | ||
| <button | ||
| type="object" | ||
| name="action_open_quants" | ||
| attrs="{'invisible':[('type', '!=', 'product')]}" | ||
| name="action_update_quantity_on_hand" | ||
| invisible="type != 'product'" | ||
| class="oe_stat_button" | ||
| icon="fa-building-o" | ||
| groups="stock.group_stock_user" |
There was a problem hiding this comment.
something must be wrong here because the button shouldnt look like this
There was a problem hiding this comment.
i don't see any changes
There was a problem hiding this comment.
It appears to be quite similar. Let me check how it behaves when a secondary unit is set for this product
There was a problem hiding this comment.
similar but not the same, the xpath is not correct and neither is the action, i think
There was a problem hiding this comment.
Please check again! Hope now should be ok
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
31d1b2b to
7524309
Compare
rov-adhoc
force-pushed
the
17.0-mig-stock_secondary_unit
branch
from
7524309 to
6ad41fc
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at b446469. Thanks a lot for contributing to OCA. ❤️ |
No description provided.