-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] stock_archive_constraint: Migration to 17.0 #2123
[17.0][MIG] stock_archive_constraint: Migration to 17.0 #2123
Conversation
…d locations with associated stock.quant or stock.move
…es have been installed
- Include context keys for avoiding mail operations overhead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review LGTM, only that suggestion to add in DESCRIPTION.md
884184b
to
82dea8f
Compare
/ocabot migration stock_archive_constraint |
|
||
@api.constrains("active") | ||
def _check_active_stock_archive_constraint(self): | ||
self.product_variant_ids._check_active_stock_archive_constraint() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this one has been removed? Is this working the same if you try to archive the template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this one has been removed? Is this working the same if you try to archive the template?
This file was never used and is not imported in init.py
And, yes, it working from product.product and product.template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at bb2c3b2. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT50326
cc: @pedrobaeza @carolinafernandez-tecnativa