Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_archive_constraint: Migration to 17.0 #2123

Merged
merged 11 commits into from
Aug 1, 2024

Conversation

carlos-lopez-tecnativa
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM, only that suggestion to add in DESCRIPTION.md

stock_archive_constraint/readme/USAGE.md Outdated Show resolved Hide resolved
@pedrobaeza
Copy link
Member

/ocabot migration stock_archive_constraint

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 1, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 1, 2024
47 tasks

@api.constrains("active")
def _check_active_stock_archive_constraint(self):
self.product_variant_ids._check_active_stock_archive_constraint()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this one has been removed? Is this working the same if you try to archive the template?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this one has been removed? Is this working the same if you try to archive the template?

This file was never used and is not imported in init.py
And, yes, it working from product.product and product.template

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2123-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3dda6b9 into OCA:17.0 Aug 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bb2c3b2. Thanks a lot for contributing to OCA. ❤️

@carlos-lopez-tecnativa carlos-lopez-tecnativa deleted the 17.0-mig-stock_archive_constraint branch August 1, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants