Skip to content

[14.0][MIG] purchase_stock_picking_invoice_link #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RabbitJon-S73
Copy link
Contributor

@RabbitJon-S73 RabbitJon-S73 commented Jun 13, 2022

purchase_stock_picking_invoice_link migration to 14.0

@rousseldenis
Copy link
Contributor

/ocabot migration purchase_stock_picking_invoice_link

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Jun 13, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 13, 2022
57 tasks
@rousseldenis
Copy link
Contributor

@RabbitJon-S73 Thanks for this.

Could you check tests ?

Moreover, when doing PR's, don't forget to make a title prettier.

@RabbitJon-S73 RabbitJon-S73 changed the title 14.0 mig purchase stock picking invoice link [14.0][MIG] purchase_stock_picking_invoice_link Jun 14, 2022
@RabbitJon-S73 RabbitJon-S73 force-pushed the 14.0-mig-purchase_stock_picking_invoice_link branch from 70c8fb7 to 9082dcc Compare June 14, 2022 09:28
@RabbitJon-S73
Copy link
Contributor Author

@rousseldenis done

@RabbitJon-S73 RabbitJon-S73 force-pushed the 14.0-mig-purchase_stock_picking_invoice_link branch from 9082dcc to eece6ba Compare June 14, 2022 14:49
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1019-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 935af09 into OCA:14.0 Jun 22, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8aaafe6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants