Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] stock_owner_restriction: Migration to 16.0 #1231

Merged
merged 11 commits into from
May 14, 2023
Merged

[MIG] stock_owner_restriction: Migration to 16.0 #1231

merged 11 commits into from
May 14, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

@rousseldenis
Copy link
Contributor

/ocabot migration stock_owner_restriction

rousseldenis
rousseldenis approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 22, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 22, 2023
Open
71 tasks
yostashiro
yostashiro approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test in a local environment. 👍

@AungKoKoLin1997 AungKoKoLin1997 mentioned this pull request Apr 4, 2023
Merged
Yadier-Tecnativa
Yadier-Tecnativa approved these changes May 8, 2023
View reviewed changes
Copy link

@Yadier-Tecnativa Yadier-Tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-stock_owner_restriction branch from 4c8f70f to e7eeefe Compare May 8, 2023 08:29
@pedrobaeza
Copy link
Member

Please don't create new commits. Just amend the last one. Now you need to squash and a new CI build will be launched, wasting CPU time.

sergio-teruel
sergio-teruel approved these changes May 14, 2023
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@sergio-teruel
Copy link
Contributor

ping @Juangomezzurita

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1231-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ff7f72a into OCA:16.0 May 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d35b6fb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@yostashiro yostashiro yostashiro approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@Yadier-Tecnativa Yadier-Tecnativa Yadier-Tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@AungKoKoLin1997 @rousseldenis @pedrobaeza @sergio-teruel @OCA-git-bot @yostashiro @Yadier-Tecnativa @ferran-S73 @cesar-tecnativa @victoralmau