[16.0][MIG] stock_picking_batch_extended: Migration to 16.0 #1236

BorisFL · 2023-02-28T13:51:33Z

No description provided.

BorisFL · 2023-03-01T15:43:25Z

[MIG] migration stock_picking_batch_extended from 15.0 to 16.0

RodrigoBM · 2023-03-13T15:40:59Z

@rousseldenis can you add to issue #1101

rousseldenis · 2023-03-13T16:08:54Z

/ocabot migration stock_picking_batch_extended

rousseldenis · 2023-03-13T16:10:10Z

@BorisFL Could you check this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0?

Could you follow especially Full process part ? Thanks

BorisFL · 2023-03-14T18:01:13Z

@BorisFL Could you check this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0?

Could you follow especially Full process part ? Thanks

Sure! I just uploaded the corrections. Can you review them to make sure they are correct?

rousseldenis

@BorisFL Thanks for this.

Unfortunately, you cannot change the authorship everywhere. Please keep them. You can add yourself in code parts you improve only.

Could you also limit your migration changes in migration commit, then, do other commit(s) for improvements ?

Thanks

.gitignore

stock_picking_batch_extended/__manifest__.py

BorisFL · 2023-03-21T13:04:44Z

@rousseldenis I have already fixed the bugs and sorry for deleting the other authors.

pedrobaeza · 2023-04-19T17:57:52Z

Please include #1276 and #1277

BorisFL · 2023-06-05T08:14:46Z

@sergio-teruel I accidentally recovered the file. Initially, I was migrating from version 14, and that's why the file got recovered. I have just deleted it now.

BorisFL · 2023-06-06T07:20:54Z

Hi @rousseldenis . I made the corrections you asked for. Please take a look at them when you can.

rousseldenis · 2023-06-06T07:30:50Z

stock_picking_batch_extended/data/batch_picking_actions_server.xml

@@ -10,11 +10,11 @@
            name="binding_model_id"
            ref="stock_picking_batch.model_stock_picking_batch"
        />
+        <field name="type">ir.actions.server</field>


No need to add this as this is the default.

rousseldenis · 2023-06-06T07:32:18Z

stock_picking_batch_extended/data/batch_picking_actions_server.xml

-action = env.ref('stock.action_report_delivery').report_action(pickings)
+        <field name="code">
+pickings = records.mapped('picking_ids').filtered(lambda p: p.state != 'cancel')
+action = env['ir.actions.report'].sudo()._get_report_from_name('stock.report_delivery').report_action(pickings)


@BorisFL Are you sure about the sudo ? As it is done in _get_report_from_name()

rousseldenis · 2023-06-06T07:32:57Z

stock_picking_batch_extended/hooks.py

@@ -6,5 +6,5 @@

 def post_init_hook(cr, registry):
    env = api.Environment(cr, SUPERUSER_ID, {})
-
-    env["res.company"].search([]).write({"use_oca_batch_validation": True})


Why changing this?

rousseldenis · 2023-06-06T08:28:13Z

stock_picking_batch_extended/models/stock_batch_picking.py

@@ -99,6 +105,22 @@ def action_print_picking(self):
    def remove_undone_pickings(self):
        """Remove of this batch all pickings which state is not done / cancel."""
        self.mapped("active_picking_ids").write({"batch_id": False})
+        self.verify_state()
+
+    def verify_state(self):


Last but not least, this is an addition in behavior from previous version.

IMHO, this module deserves a good DESCRIPTION.rst in readme folder to explain what it does as 'extended' is too general term to understand at first sight. Thanks

I have fixed it. I have cleaned up some errors from an initial import I made from v14, and the only change is the removal of "remove_undone_pickings." This change ensures that when a picking is canceled, its grouping is removed in v16

Ok, nevertheless, a good module description could be a great improvement 😃

I have added a description to the readme and index files

FrancoMaxime

LGTM, minor suggestion

FrancoMaxime · 2023-06-07T09:46:39Z

stock_picking_batch_extended/__manifest__.py

 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

 {
    "name": "Stock batch picking extended",
    "summary": "Allows manage a lot of pickings in batch",
-    "version": "15.0.2.2.0",
+    "version": "16.0.1.0.0",
    "author": "Camptocamp, " "Tecnativa, " "Odoo Community Association (OCA)",


Hi @BorisFL , thanks for contributing.
can you fix this old pre-commit result?

Suggested change

"author": "Camptocamp, " "Tecnativa, " "Odoo Community Association (OCA)",

"author": "Camptocamp, Tecnativa, Odoo Community Association (OCA)",

I have fixed the concatenation of the authors

rousseldenis · 2023-06-07T14:19:31Z

@pedrobaeza @sergio-teruel Could you update your review ?

BorisFL · 2023-06-12T07:16:04Z

Hello @pedrobaeza and @sergio-teruel .

I have made the mentioned modifications. Can you review them?

BorisFL · 2023-06-14T07:32:49Z

Good morning @pedrobaeza and @sergio-teruel , I apologize for insisting, but have you received any notification? Can you review your comments?

Letting others to decide

xAdrianCif · 2023-06-19T16:17:43Z

Hello, @sergio-teruel Could you review the changes made and leave an approval if you think it's appropriate? If you see the need for any additional changes, please let me know. From now on, I will take care of this PR, so if anyone thinks we should make any changes, please let me know as well! Thanks to all!

xAdrianCif · 2023-06-21T10:44:39Z

Hello everyone, the person who developed and maintained this PR is no longer collaborating with our company. We have detect some minor issues so we have decided to close it, reanalyze it, and develop it again. We will upload the new one as soon as possible.

PD: I do not have the permissions to close this PR. If someone could do it, I would greatly appreciate it.

CC @pedrobaeza @rousseldenis @sergio-teruel @FrancoMaxime

nicomacr · 2023-07-10T17:39:48Z

@xAdrianC-FactorLibre any news about the new PR of the module?

xAdrianCif · 2023-07-11T13:03:55Z

Hello @nicomacr , we have conducted a preliminary analysis and believe that changes need to be made compared to the previous MR. However, I cannot provide much information regarding actions or possible dates as we are currently focused on other priorities.

xAdrianCif · 2023-08-11T12:59:51Z

@nicomacr @rousseldenis @FrancoMaxime
Hello everyone, a colleague has carried out the migration that was postponed in this issue. I'll leave the link here in case you're still interested. Thank you!
#1353

nicomacr · 2023-08-11T14:15:21Z

@xAdrianCif Thank you for taking care of the migration of the module.

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch 4 times, most recently from 07720a7 to 15feeec Compare March 1, 2023 15:38

BorisFL changed the title ~~[MIG] migration stock_picking_batch_extended from 14.0 to 16.0~~ [16.0][MIG] migration stock_picking_batch_extended from 14.0 to 16.0 Mar 13, 2023

BorisFL changed the title ~~[16.0][MIG] migration stock_picking_batch_extended from 14.0 to 16.0~~ [16.0][MIG] stock_picking_batch_extended: Migration to 16.0 Mar 13, 2023

rousseldenis added needs review migration labels Mar 13, 2023

OCA-git-bot added this to the 16.0 milestone Mar 13, 2023

OCA-git-bot mentioned this pull request Mar 13, 2023

Migration to version 16.0 #1101

Open

70 tasks

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch from 15feeec to aa93955 Compare March 14, 2023 17:53

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch 3 times, most recently from e012f47 to 0b2abca Compare March 16, 2023 16:52

rousseldenis requested changes Mar 20, 2023

View reviewed changes

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch 7 times, most recently from f8ad4d7 to b3a772d Compare March 21, 2023 12:55

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch from b3a772d to 5cc3df7 Compare April 24, 2023 10:11

rousseldenis reviewed Jun 6, 2023

View reviewed changes

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch from c39c508 to 42562f7 Compare June 6, 2023 08:24

rousseldenis reviewed Jun 6, 2023

View reviewed changes

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch 8 times, most recently from fe1c794 to 9217cb2 Compare June 6, 2023 20:04

FrancoMaxime approved these changes Jun 7, 2023

View reviewed changes

[MIG] migration stock_picking_batch_extended from 15.0 to 16.0

989b691

BorisFL force-pushed the 16.0-mig-stock_picking_batch_extended branch from 9217cb2 to 989b691 Compare June 7, 2023 14:16

rousseldenis approved these changes Jun 7, 2023

View reviewed changes

pedrobaeza closed this Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] stock_picking_batch_extended: Migration to 16.0 #1236

[16.0][MIG] stock_picking_batch_extended: Migration to 16.0 #1236

BorisFL commented Feb 28, 2023

BorisFL commented Mar 1, 2023 •

edited

Loading

RodrigoBM commented Mar 13, 2023

rousseldenis commented Mar 13, 2023

rousseldenis commented Mar 13, 2023 •

edited

Loading

BorisFL commented Mar 14, 2023

rousseldenis left a comment

BorisFL commented Mar 21, 2023

pedrobaeza commented Apr 19, 2023

BorisFL commented Jun 5, 2023

BorisFL commented Jun 6, 2023

rousseldenis Jun 6, 2023

BorisFL Jun 7, 2023

rousseldenis Jun 6, 2023

BorisFL Jun 7, 2023

rousseldenis Jun 6, 2023

rousseldenis Jun 6, 2023

BorisFL Jun 6, 2023 •

edited

Loading

rousseldenis Jun 7, 2023

BorisFL Jun 7, 2023

FrancoMaxime left a comment

FrancoMaxime Jun 7, 2023

BorisFL Jun 7, 2023

FrancoMaxime Jun 7, 2023

rousseldenis commented Jun 7, 2023

BorisFL commented Jun 12, 2023

BorisFL commented Jun 14, 2023

xAdrianCif commented Jun 19, 2023

xAdrianCif commented Jun 21, 2023

nicomacr commented Jul 10, 2023

xAdrianCif commented Jul 11, 2023

xAdrianCif commented Aug 11, 2023

nicomacr commented Aug 11, 2023

	"author": "Camptocamp, " "Tecnativa, " "Odoo Community Association (OCA)",
	"author": "Camptocamp, Tecnativa, Odoo Community Association (OCA)",

[16.0][MIG] stock_picking_batch_extended: Migration to 16.0 #1236

[16.0][MIG] stock_picking_batch_extended: Migration to 16.0 #1236

Conversation

BorisFL commented Feb 28, 2023

BorisFL commented Mar 1, 2023 • edited Loading

RodrigoBM commented Mar 13, 2023

rousseldenis commented Mar 13, 2023

rousseldenis commented Mar 13, 2023 • edited Loading

BorisFL commented Mar 14, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

BorisFL commented Mar 21, 2023

pedrobaeza commented Apr 19, 2023

BorisFL commented Jun 5, 2023

BorisFL commented Jun 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BorisFL Jun 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FrancoMaxime left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Jun 7, 2023

BorisFL commented Jun 12, 2023

BorisFL commented Jun 14, 2023

xAdrianCif commented Jun 19, 2023

xAdrianCif commented Jun 21, 2023

nicomacr commented Jul 10, 2023

xAdrianCif commented Jul 11, 2023

xAdrianCif commented Aug 11, 2023

nicomacr commented Aug 11, 2023

BorisFL commented Mar 1, 2023 •

edited

Loading

rousseldenis commented Mar 13, 2023 •

edited

Loading

BorisFL Jun 6, 2023 •

edited

Loading