[16.0][MIG] stock_picking_show_return: Migration to 16.0 #1237

slitheryduke11 · 2023-03-06T06:01:38Z

No description provided.

============================== Show returns on stock pickings ============================== This module enables one tab in the pickings that contains returns made for that picking.

The returned picking must be obtained from the picking of the iteration, not the set of pickings to be calculated.

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

For avoiding errors when other modules add required fields on affected models

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_show_return Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_show_return/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_picking_show_return Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_picking_show_return/

Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_picking_show_return Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_picking_show_return/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_picking_show_return Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_picking_show_return/

…t due to this Odoo commit OCA/OCB@8ca10a8

desdelinux

LGTM

desdelinux · 2023-03-09T16:37:18Z

Functional test. Work as expected

@dreispt @pedrobaeza This is ready.

luisg123v · 2023-03-09T17:53:12Z

stock_picking_show_return/tests/test_stock_picking_show_return.py

+                "location_dest_id": picking_type.default_location_dest_id.id,
+                "move_ids": [
+                    (
+                        0,


Use Command syntax, please

luisg123v · 2023-03-09T17:55:27Z

stock_picking_show_return/models/stock_picking.py

+        """Get source piking from this picking. Only one origin is possible."""
+        for picking in self:
+            picking.source_picking_id = first(
+                picking.mapped("move_ids.origin_returned_move_id.picking_id")


Mapped not required anymore when the field is a recordset, see odoo/odoo#32897

Suggested change

picking.mapped("move_ids.origin_returned_move_id.picking_id")

picking.move_ids.origin_returned_move_id.picking_id

Please apply this in all similar cases

luisg123v · 2023-03-09T17:57:30Z

stock_picking_show_return/i18n/stock_picking_show_return.pot

+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 15.0\n"


16.0.

Please re-generate this file (only the template)

luisg123v · 2023-03-09T17:59:22Z

stock_picking_show_return/tests/test_stock_picking_show_return.py

+
+@tagged("post_install", "-at_install")
+class TestStockPickingShowReturn(TransactionCase):
+    def setUp(self):


Suggested change

def setUp(self):

@classmethod

def setUpClass(cls):

slitheryduke11 · 2023-03-28T17:20:56Z

Hello @luisg123v.

All changes have been applied.

luisg123v

LGTM 👍

@moylop260 could you review/merge, please?

OCA-git-bot · 2023-03-29T01:00:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis

Code review

rousseldenis · 2023-03-29T06:47:26Z

/ocabot merge patch

OCA-git-bot · 2023-03-29T08:33:42Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1237-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2023-03-29T08:41:24Z

Congratulations, your PR was merged at 3287b8e. Thanks a lot for contributing to OCA. ❤️

luisg123v · 2023-03-29T15:11:01Z

Thanks @rousseldenis.

FYI when migrations are merged, that's usually done using nobump instead of patch, to make the version to stay in 16.0.1.0.0

rousseldenis · 2023-04-05T14:55:32Z

Thanks @rousseldenis.

FYI when migrations are merged, that's usually done using nobump instead of patch, to make the version to stay in 16.0.1.0.0

Yes from >= 15, pre-releases are not done anymore on pypi. I forgot that information. That's why I'd always prefer use patch before. So, usage of nobump is encouraged now

pedrobaeza and others added 30 commits March 5, 2023 20:30

[REN] stock_picking_show_returns > stock_picking_show_return

663611a

stock_picking_show_return

92c8a2c

============================== Show returns on stock pickings ============================== This module enables one tab in the pickings that contains returns made for that picking.

stock_picking_show_return: Tests

003df44

stock_picking_show_return: Migrated to 9.0

2edf639

stock_picking_show_return: Typo

a7943fd

The returned picking must be obtained from the picking of the iteration, not the set of pickings to be calculated.

[MIG] stock_picking_show_return: Migration to 10.0

7e54351

[IMP] stock_*: Execute tests at the end

64d8996

For avoiding errors when other modules add required fields on affected models

[MIG] Migrated stock_picking_show_return to v11.0

786b445

remove obsolete .pot files [ci skip]

0d8e02c

[UPD] Update stock_picking_show_return.pot

dcc2537

[MIG]stock_picking_show_return: migration from 11 to v12

34be8cd

[UPD] README.rst

3e28033

[UPD] Update stock_picking_show_return.pot

425738f

[ADD] icon.png

c614417

[UPD] README.rst

8286c9c

[IMP] stock_picking_show_return: black, isort

1112c93

[MIG] stock_picking_show_return: Migration to v13.0

eea7df8

[UPD] Update stock_picking_show_return.pot

af90d43

pre-commit update

6b3755c

Added translation using Weblate (Chinese (Simplified))

e295a66

[IMP] stock_picking_show_return: black, isort, prettier

588e077

[MIG] stock_picking_show_return: Migration to 14.0

9cb0213

[UPD] Update stock_picking_show_return.pot

46707a4

[UPD] README.rst

7df2da4

[FIX] stock_picking_show_return: Use Form in tests to avoid crash tes…

fbfc783

…t due to this Odoo commit OCA/OCB@8ca10a8

OCA-git-bot added this to the 16.0 milestone Mar 6, 2023

OCA-git-bot mentioned this pull request Mar 6, 2023

Migration to version 16.0 #1101

Open

75 tasks

desdelinux approved these changes Mar 6, 2023

View reviewed changes

OCA-git-bot added the approved label Mar 6, 2023

luisg123v suggested changes Mar 9, 2023

View reviewed changes

OCA-git-bot removed the approved label Mar 9, 2023

slitheryduke11 force-pushed the 16.0-mig-stock_picking_show_return branch 3 times, most recently from cde2822 to 2e32927 Compare March 19, 2023 21:16

slitheryduke11 force-pushed the 16.0-mig-stock_picking_show_return branch from 2e32927 to 8812231 Compare March 28, 2023 01:42

slitheryduke11 added 2 commits March 28, 2023 12:05

[IMP] stock_picking_show_return: pre-commit stuff

062b05d

[MIG] stock_picking_show_return: Migration to 16.0

b61678f

slitheryduke11 force-pushed the 16.0-mig-stock_picking_show_return branch from 8812231 to b61678f Compare March 28, 2023 18:37

luisg123v approved these changes Mar 29, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 29, 2023

rousseldenis approved these changes Mar 29, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 29, 2023

OCA-git-bot merged commit 2ebc5d8 into OCA:16.0 Mar 29, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 29, 2023

luisg123v deleted the 16.0-mig-stock_picking_show_return branch March 29, 2023 15:09

	picking.mapped("move_ids.origin_returned_move_id.picking_id")
	picking.move_ids.origin_returned_move_id.picking_id

Uh oh!

[16.0][MIG] stock_picking_show_return: Migration to 16.0 #1237

[16.0][MIG] stock_picking_show_return: Migration to 16.0 #1237

Uh oh!

Conversation

slitheryduke11 commented Mar 6, 2023

Uh oh!

desdelinux left a comment

Choose a reason for hiding this comment

Uh oh!

desdelinux commented Mar 9, 2023

Uh oh!

luisg123v Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

luisg123v Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

luisg123v Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

luisg123v Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

slitheryduke11 commented Mar 28, 2023

Uh oh!

luisg123v left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 29, 2023

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Mar 29, 2023

Uh oh!

OCA-git-bot commented Mar 29, 2023

Uh oh!

OCA-git-bot commented Mar 29, 2023

Uh oh!

luisg123v commented Mar 29, 2023

Uh oh!

rousseldenis commented Apr 5, 2023

Uh oh!

Uh oh!