Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.0 mig stock_picking_info_lot #1304

Merged
merged 6 commits into from
Jul 4, 2023
Merged

16.0 mig stock_picking_info_lot #1304

merged 6 commits into from
Jul 4, 2023

Conversation

juanmagil
Copy link
Contributor

No description provided.

ZavarinArtem and others added 6 commits June 5, 2023 13:10
@ZavarinArtem @juanmagil
[ADD] added stock_picking_info_lot module
4c2647a 
[ADD] added readme folder and content

[IMP] check with pre-commits

[FIX] renamed views file to follow guideline

[15.0][ADD] added setup files

[15.0][ADD] added setup files

[15.0][IMP] re-write DESCRIPTION.rst

[IMP] stock_picking_info_lot: require lot info upon validation

[ADD] added unit test for validation check

[ADD] recreating setup files

[ADD] recreating setup files

[ADD] added ROADMAP.rst
@juanmagil
[UPD] Update stock_picking_info_lot.pot
370dce8
@OCA-git-bot @juanmagil
[UPD] README.rst
0c91aa9
@OCA-git-bot @juanmagil
[ADD] icon.png
c0ec3e9
@juanmagil
[IMP] stock_picking_info_lot: pre-commit stuff
2337d18
@juanmagil
[MIG] stock_picking_info_lot: Migration to 16.0
d5d2239
@elarapuntsistemes elarapuntsistemes mentioned this pull request Jun 5, 2023
Open
70 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_info_lot

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 5, 2023
rousseldenis
rousseldenis approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

hugo-cordoba
hugo-cordoba approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@hugo-cordoba hugo-cordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

elarapuntsistemes
elarapuntsistemes approved these changes Jun 5, 2023
View reviewed changes
Copy link

@elarapuntsistemes elarapuntsistemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test

ferran-S73
ferran-S73 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ferran-S73 ferran-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Jul 4, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1304-by-dreispt-bump-nobump, awaiting test results.

@dreispt dreispt changed the title 16.0 mig stock picking info lot 16.0 mig stock_picking_info_lot Jul 4, 2023
@OCA-git-bot OCA-git-bot merged commit 1e79675 into OCA:16.0 Jul 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1256580. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-cordoba hugo-cordoba hugo-cordoba approved these changes

@ferran-S73 ferran-S73 ferran-S73 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@elarapuntsistemes elarapuntsistemes elarapuntsistemes approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@juanmagil @rousseldenis @OCA-git-bot @dreispt @elarapuntsistemes @ferran-S73 @hugo-cordoba @ZavarinArtem