Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465

Open
wants to merge 76 commits into
base: 16.0
Choose a base branch
from

Conversation

AungKoKoLin1997
Copy link
Contributor

Standard Migration

@qrtl

@AaronHForgeFlow
Copy link
Contributor

The readme is quite short. How can I do a functional test on this module? creating a inventory adjustment on a past date? Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves?

@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Jan 4, 2024

How can I do a functional test on this module? creating a inventory adjustment on a past date?

@AaronHForgeFlow I didn't test with inventory adjustment. For clear testing, I test with this module OCA/purchase-workflow#2137. So, we can adjust the price_unit of move from purchase order line.

Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves?

Yes, It does and also adjusts the cost of product.

@rousseldenis
Copy link
Contributor

/ocabot migration product_cost_price_avco_sync

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 22b0a0c to 52228bb Compare April 10, 2024 08:41
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 52228bb to 32f5cef Compare June 12, 2024 03:55
sergio-teruel and others added 18 commits June 12, 2024 09:28
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_cost_price_avco_sync/
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_cost_price_avco_sync/pt_BR/
… with same product and distinct price are done at same second.
oca-ci and others added 11 commits June 12, 2024 09:28
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/es/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/it/
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch 2 times, most recently from 4f81c7b to f1525e7 Compare June 13, 2024 04:07
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@AaronHForgeFlow
Copy link
Contributor

@AungKoKoLin1997 can you please rebase so runboat is rebuilt? Thanks

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from f1525e7 to 3033869 Compare October 14, 2024 13:30
@AungKoKoLin1997
Copy link
Contributor Author

@AaronHForgeFlow I rerun the runboat.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@AungKoKoLin1997
Copy link
Contributor Author

@rousseldenis Can we get this PR merged?

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1465-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 15, 2024
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1465-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AungKoKoLin1997
Copy link
Contributor Author

@rousseldenis I checked the failed and the issue will be fixed by the PR I created #1760.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.