-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465
base: 16.0
Are you sure you want to change the base?
[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465
Conversation
The readme is quite short. How can I do a functional test on this module? creating a inventory adjustment on a past date? Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves? |
@AaronHForgeFlow I didn't test with inventory adjustment. For clear testing, I test with this module OCA/purchase-workflow#2137. So, we can adjust the price_unit of move from purchase order line.
Yes, It does and also adjusts the cost of product. |
/ocabot migration product_cost_price_avco_sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
22b0a0c
to
52228bb
Compare
52228bb
to
32f5cef
Compare
…ith stock move price unit
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_cost_price_avco_sync Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_cost_price_avco_sync/
…lue before BD write.
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_cost_price_avco_sync Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_cost_price_avco_sync/pt_BR/
… with same product and distinct price are done at same second.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/es/
Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/it/
4f81c7b
to
f1525e7
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@AungKoKoLin1997 can you please rebase so runboat is rebuilt? Thanks |
f1525e7
to
3033869
Compare
@AaronHForgeFlow I rerun the runboat. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
@rousseldenis Can we get this PR merged? |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1465-by-rousseldenis-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@rousseldenis I checked the failed and the issue will be fixed by the PR I created #1760. |
Standard Migration
@qrtl