Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_picking_group_by_partner_by_carrier_by_date: Migration to 16.0 #1528

Merged
merged 11 commits into from
May 7, 2024
Merged

[16.0][MIG] stock_picking_group_by_partner_by_carrier_by_date: Migration to 16.0 #1528

merged 11 commits into from
May 7, 2024

Conversation

tuantrantg
Copy link
Contributor

No description provided.

simahawk and others added 9 commits March 7, 2024 14:51
@simahawk @tuantrantg
Add stock_picking_group_by_partner_by_carrier_by_date
ced6ef3
@simahawk @tuantrantg
s_picking_group_by_partner_by_carrier_by_date: rely on picking type flag
b2fead9
@simahawk @tuantrantg
stock_picking_group_by_* rebase on stock_move_assign_picking_hook
6ac0bef
@simahawk @tuantrantg
s_picking_group_by_partner_by_carrier: add merge wizard
2eabbfe
@phuctranfxvn @tuantrantg
[MIG] stock_picking_group_by_partner_by_carrier_by_date: Migration to…
9282593 
… 14.0
@sebalix @tuantrantg
[FIX] s_by_carrier_by_date: group same day different time
a3393cb
@mymage @tuantrantg
Added translation using Weblate (Italian)
7bfb6f3
@mymage @tuantrantg
Translated using Weblate (Italian)
de2fbe1 
Currently translated at 100.0% (7 of 7 strings)

Translation: stock-logistics-workflow-14.0/stock-logistics-workflow-14.0-stock_picking_group_by_partner_by_carrier_by_date
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-14-0/stock-logistics-workflow-14-0-stock_picking_group_by_partner_by_carrier_by_date/it/
@tuantrantg
[IMP] stock_picking_group_by_partner_by_carrier_by_date: pre-commit s…
1c5b5af 
…tuff
@tuantrantg tuantrantg marked this pull request as draft March 7, 2024 08:32
@tuantrantg tuantrantg force-pushed the 16.0-mig-stock_picking_group_by_partner_by_carrier_by_date branch 2 times, most recently from 34fcfad to 8c323a0 Compare March 8, 2024 04:07
@tuantrantg tuantrantg force-pushed the 16.0-mig-stock_picking_group_by_partner_by_carrier_by_date branch from 8c323a0 to 8fd905d Compare March 8, 2024 07:40
@tuantrantg tuantrantg marked this pull request as ready for review March 8, 2024 08:08
@tuantrantg tuantrantg force-pushed the 16.0-mig-stock_picking_group_by_partner_by_carrier_by_date branch from 8fd905d to b6ba5f3 Compare March 8, 2024 08:41
simahawk
simahawk approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the fix has to be backported ?

@tuantrantg
Copy link
Contributor Author

I guess the fix has to be backported ?

hi @simahawk #1534 has been created for the backport

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_group_by_partner_by_carrier_by_date

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 11, 2024
Open
70 tasks
rousseldenis
rousseldenis reviewed Mar 11, 2024
View reviewed changes
stock_picking_group_by_partner_by_carrier_by_date/models/stock_move.py
@@ -25,10 +32,22 @@ def _assign_picking_group_domain_by_date(self):
domain = []
if self._skip_assign_picking_group_domain_by_date():
return domain
date_planned = self.date.replace(hour=0, minute=0, second=0)
date_planned_end = date_planned.replace(hour=23, minute=59, second=59)
tz = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuantrantg Is there a test for timezones ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuantrantg little ping, any news here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit busy right now, I will come back soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @rousseldenis the test is added, could you please take a look

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tuantrantg tuantrantg force-pushed the 16.0-mig-stock_picking_group_by_partner_by_carrier_by_date branch from b6ba5f3 to 6996df1 Compare April 17, 2024 07:55
@jbaudoux
Copy link
Contributor

jbaudoux commented May 7, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1528-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5935540 into OCA:16.0 May 7, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2152f77. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@cyrilmanuel cyrilmanuel cyrilmanuel left review comments

@jbaudoux jbaudoux jbaudoux approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@tuantrantg @rousseldenis @OCA-git-bot @jbaudoux @simahawk @cyrilmanuel @phuctranfxvn @sebalix @mymage