Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_product_set: Migration to version 16.0 #1538

Merged
merged 4 commits into from
Mar 14, 2024
Merged

[16.0][MIG] stock_product_set: Migration to version 16.0 #1538

merged 4 commits into from
Mar 14, 2024

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Mar 12, 2024 •
edited by pedrobaeza
Loading

victoralmau
victoralmau suggested changes Mar 12, 2024
View reviewed changes
@rousseldenis
Copy link
Contributor

/ocabot migration stock_product_set

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 12, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 12, 2024
Open
71 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-stock_product_set branch 2 times, most recently from eecd73f to 6be9e89 Compare March 12, 2024 16:43
@pilarvargas-tecnativa
Copy link
Contributor Author

@victoralmau Changes made to eliminate dependency at OCA/product-attribute#1548

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-stock_product_set branch 2 times, most recently from 41425bb to ee3002c Compare March 12, 2024 17:14
@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Mar 12, 2024
Merged
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-stock_product_set branch from ee3002c to abcc4e7 Compare March 14, 2024 07:53
victoralmau
victoralmau approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.

carolinafernandez-tecnativa
carolinafernandez-tecnativa approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM, Thanks :)

pedrobaeza
pedrobaeza approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1538-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f71d0b2 into OCA:16.0 Mar 14, 2024
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e45a574. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-stock_product_set branch March 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carolinafernandez-tecnativa carolinafernandez-tecnativa carolinafernandez-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pilarvargas-tecnativa @rousseldenis @OCA-git-bot @victoralmau @pedrobaeza @carolinafernandez-tecnativa