Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_move_backdating #1594

Open
wants to merge 70 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] stock_move_backdating #1594

wants to merge 70 commits into from

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented May 15, 2024 •
edited
Loading

This PR migrated from version15 and enhance to supported backdate scrap

@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from 5996980 to d49ebcc Compare May 15, 2024 11:00
@rousseldenis
Copy link
Contributor

/ocabot migration stock_move_backdating

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 16, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 16, 2024
Open
70 tasks
@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from 4eb6454 to 361ac67 Compare May 24, 2024 03:06
@rousseldenis
Copy link
Contributor

@Saran440 Could you fix pre-commit and enhance your commit messages ? Thanks

@alessandro-fiorino
Copy link

I've made a pull to fix the pre-commit errors ecosoft-odoo#2

tafaRU and others added 21 commits August 1, 2024 16:20
@tafaRU @Saran440
[ADD] stock_move_backdating
021175c
@tafaRU @Saran440
[FIX]stock_move_backdating: stock_view.xml
b29e433
@eLBati @Saran440
[FIX] authors
1000248
@tafaRU @Saran440
[REF] stock_partial_picking_line
3204c92
@tafaRU @Saran440
[FIX] changed view
7105998
@eLBati @Saran440
[imp] use back date for accounting
3268cf3
@eLBati @Saran440
[imp] orm.Model
a11d1ff
@eLBati @Saran440
[imp] use move date and related period
bb1017b
@eLBati @Saran440
[add] missing account.py
8312f32
@tafaRU @Saran440
[FIX] stock_partial_picking_line
9c76821
@tafaRU @Saran440
[ADD] override to _partial_move_for and to do_partial in stock.partia…
539c017 
…l.picking
@eLBati @Saran440
[fix] wrong create return value
fdaa4c9
@tafaRU @Saran440
[FIX] remove pdb
50db0b4
@tafaRU @Saran440
[ADD] AUTHORS and copyright
44d0a6a
@tafaRU @Saran440
[ADD] mail address to AUTHORS.txt
3376057
@tafaRU @Saran440
[FIX] PEP 8 and OpenERP syntax compliance
de40f20
@eLBati @Saran440
[FIX] using right date: move.date_backdating
514915d
@tafaRU @Saran440
[FIX]replaced m by move and avoid extra spaces
e01db5a
@eLBati @Saran440
[FIX] when move.date_backdating is not set
27ff2d9
@eLBati @Saran440
[IMP] stock_move_backdating and stock_picking_invoice_link descriptions
4b134a1
@gurneyalex @Saran440
mark unported module as uninstallable
c36ed74
SirTakobi and others added 24 commits August 1, 2024 16:20
@SirTakobi @Saran440
[MIG] stock_move_backdating: Migration to 12.0
bad5bca
@SirTakobi @Saran440
[IMP] stock_move_backdating: Update source quant date
36f134b
@SirTakobi @Saran440
[IMP] stock_move_backdating: Show date in picking
46a09f6
@SirTakobi @Saran440
[IMP] stock_move_backdating: Allow to backdate inventory
d865759
@SirTakobi @Saran440
[I18N] stock_move_backdating: Update Italian and POT
ae72dce
@SirTakobi @rousseldenis @Saran440
[IMP] stock_move_backdating: Performance
bc50f35 
Co-authored-by: Denis Roussel <denis.roussel@acsone.eu>
@Saran440
[UPD] Update stock_move_backdating.pot
4c23d0b
@OCA-git-bot @Saran440
[UPD] README.rst
ce7be5f
@OCA-git-bot @Saran440
stock_move_backdating 12.0.1.0.1
45418e1
@mymage @Saran440
Translated using Weblate (Italian)
f5bcd4e 
Currently translated at 95.4% (21 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
@francesco-ooops @Saran440
Translated using Weblate (Italian)
338eec6 
Currently translated at 95.4% (21 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
@OCA-git-bot @Saran440
[UPD] README.rst
184f3ee
@mymage @Saran440
Translated using Weblate (Italian)
90ee434 
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
@weblate @Saran440
Update translation files
4fae2b5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/
@mymage @Saran440
Translated using Weblate (Italian)
5e5e4af 
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
@mymage @Saran440
Translated using Weblate (Italian)
242bf9a 
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
@toita86 @Saran440
[IMP] stock_move_backdating: black, isort, prettier
3debb50
@toita86 @Saran440
[MIG] stock_move_backdating: Migration to 14.0
aea1945
@Saran440
[UPD] Update stock_move_backdating.pot
dbf6f43
@OCA-git-bot @Saran440
[BOT] post-merge updates
dba4559
@ps-tubtim @Saran440
[IMP] stock_move_backdating: black, isort, prettier
da084d5
@ps-tubtim @Saran440
[MIG] stock_move_backdating: Migration to 15.0
96a44d8
@Saran440
[MIG] stock_move_backdating: Migration to 16.0
5003100
@Saran440
[ENH] Scrap: back date
ca8e33d
@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from f7200b3 to ca8e33d Compare August 1, 2024 09:20
@Saran440
Copy link
Member Author

Saran440 commented Aug 1, 2024

@alessandro-fiorino Thank you for your contribution.
Now, I fixes it. Could you help review please?

@alessandro-fiorino
Copy link

It fails some test. I think the problem is in the test itself https://github.com/ecosoft-odoo/stock-logistics-workflow/blob/ca8e33d35f67f5716e349230eda9285074873212/stock_move_backdating/tests/common.py#L66
standard_price is enabled only if the product has variants.

@Saran440
Copy link
Member Author

Updated:

  • Change method update date in account move from _backdating_account_moves to _account_entry_move, Fixed for case backdating previous month it will error doesn't match date and sequence move
  • Fixed test script

arielbarreiros96
arielbarreiros96 reviewed Dec 3, 2024
View reviewed changes
Copy link

@arielbarreiros96 arielbarreiros96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed if from a functional perspective and it looks good, I tested mainly the backdating at the moment of making inventory adjustments. I do think the Readme file could include a Usage section, I literally had to read the code to know what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielbarreiros96 arielbarreiros96 arielbarreiros96 left review comments

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.