Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] stock_picking_invoice_link: Avoid doble compute picking_count #1636

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[16.0][FIX] stock_picking_invoice_link: Avoid doble compute picking_count #1636

merged 1 commit into from
Jun 20, 2024

Conversation

Segui-S73
Copy link
Contributor

After the change added in the commit [FIX] stock_picking_invoice_link: Avoid inconsistent computes the picking_count field is being calculated twice.
This generates a strange interaction with the "payment.return" when confirming in which it checks if the generated account.move is balanced ahead of time and prevents it from being created.

@rousseldenis
Copy link
Contributor

Thanks @Segui-S73!

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 20, 2024
@pedrobaeza pedrobaeza changed the title [FIX] stock_picking_invoice_link: Avoid doble compute picking_count [16.0][FIX] stock_picking_invoice_link: Avoid doble compute picking_count Jun 20, 2024
pedrobaeza
pedrobaeza approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

cc @chienandalu

Is this present in other versions?

/ocabot merge patch

chienandalu
chienandalu reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is this present in other versions?

Yes it is 😞

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1636-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 20, 2024
@OCA-git-bot
Merge PR #1636 into 16.0
43f9215 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit ceccc59 into OCA:16.0 Jun 20, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6556f40. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1636-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Sorry for the double merging command. I cancelled mine.

@fuentes73 fuentes73 deleted the 16.0-fix-stock_picking_invoice_link branch June 20, 2024 14:12
@rousseldenis rousseldenis mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu left review comments

@rousseldenis rousseldenis rousseldenis approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@fuentes73 fuentes73 fuentes73 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Segui-S73 @rousseldenis @OCA-git-bot @pedrobaeza @fuentes73 @chienandalu