Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_picking_return_lot #1677

Merged
merged 6 commits into from
Sep 2, 2024
Merged

[16.0][MIG] stock_picking_return_lot #1677

merged 6 commits into from
Sep 2, 2024

Conversation

sbejaoui
Copy link
Contributor

  • Add a lot field to the return wizard and create a return line for each lot/product combination.
  • Use Stock Restrict Lot to track the accepted lot on the return picking.

image

image

image

image

cc/ @jbaudoux , @rousseldenis , @lmignon

@sbejaoui sbejaoui changed the title [MIG] stock_picking_return_lot [16.0][MIG] stock_picking_return_lot Aug 20, 2024
@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_return_lot

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 21, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 21, 2024
Open
70 tasks
rousseldenis
rousseldenis approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@sbejaoui sbejaoui mentioned this pull request Aug 22, 2024
Merged
@matt454357 matt454357 mentioned this pull request Aug 22, 2024
Open
@sbejaoui sbejaoui force-pushed the 16.0-stock_picking_return_lot-sbj branch from 1cf5108 to 97c2b7c Compare August 27, 2024 09:50
jbaudoux
jbaudoux reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract from the migration commit the enhancements so that the migration commit remains as small as possible ?

AungKoKoLin1997
AungKoKoLin1997 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbejaoui
[16.0][MIG] stock_picking_return_lot
4393a37
@sbejaoui
[IMP] stock_picking_return_lot: Add a lot field to the return wizard
4f8c3f5 
- Add a lot field to the return wizard and create a return line for each lot/product combination.
- Use Stock Restrict Lot to track the accepted lot on the return picking.
@sbejaoui sbejaoui force-pushed the 16.0-stock_picking_return_lot-sbj branch from 97c2b7c to 4f8c3f5 Compare September 2, 2024 11:11
@sbejaoui
Copy link
Contributor Author

sbejaoui commented Sep 2, 2024

Can you extract from the migration commit the enhancements so that the migration commit remains as small as possible ?

done

jbaudoux
jbaudoux approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaudoux
Copy link
Contributor

jbaudoux commented Sep 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1677-by-jbaudoux-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c887111 into OCA:16.0 Sep 2, 2024
10 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 44d1fc9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sbejaoui @rousseldenis @OCA-git-bot @jbaudoux @AungKoKoLin1997 @renda-dev