-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Make check in quant level so that it works in manufacturing as well #256
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# -*- coding: utf-8 -*- | ||
############################################################################## | ||
# | ||
# Copyright (C) 2016, Eska Yazılım ve Danışmanlık A.Ş. | ||
# http://www.eskayazilim.com.tr | ||
# | ||
# This program is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU Affero General Public License as | ||
# published by the Free Software Foundation, either version 3 of the | ||
# License, or (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU Affero General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Affero General Public License | ||
# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
############################################################################## | ||
from openerp import api, _, exceptions, models | ||
|
||
|
||
class StockQuant(models.Model): | ||
_inherit = 'stock.quant' | ||
|
||
@api.model | ||
def _quant_create(self, qty, move, lot_id=False, owner_id=False, | ||
src_package_id=False, dest_package_id=False, | ||
force_location_from=False, force_location_to=False): | ||
if move.product_id.check_no_negative \ | ||
and move.location_id.usage == 'internal': | ||
lot_msg_str = "" | ||
if lot_id: | ||
lot = self.env['stock.production.lot'].browse(lot_id) | ||
lot_msg_str = _(" with the lot/serial '%s' ") % lot.name | ||
raise exceptions.ValidationError(_( | ||
"Product '%s' has active " | ||
"'check no negative' \n" | ||
"but with this move " | ||
"you will have a quantity of " | ||
"'%s' \n%sin location \n'%s'" | ||
) % (move.product_id.name, | ||
move.product_id.qty_available - move.product_uom_qty, | ||
lot_msg_str, | ||
move.location_id.name,)) | ||
return super(StockQuant, self)._quant_create( | ||
qty, move, lot_id=lot_id, owner_id=owner_id, | ||
src_package_id=src_package_id, dest_package_id=dest_package_id, | ||
force_location_from=force_location_from, | ||
force_location_to=force_location_to) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not checking here if qty is negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_quant_create is called when negative otherwise _quant_split is called.
yes it is not self explanatory but it works like a charm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see, please document it then properly, indicating that always that this method is called and the location is internal, a negative quant is created.