Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] Migration of stock_picking_auto_create_lot #506

Merged
merged 8 commits into from
Nov 28, 2019
Merged

[12.0][MIG] Migration of stock_picking_auto_create_lot #506

merged 8 commits into from
Nov 28, 2019

Conversation

meigallodixital
Copy link
Contributor

Migration proposal

@oca-clabot
Copy link

Hey @meigallodixital, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@OCA-git-bot OCA-git-bot mentioned this pull request Feb 25, 2019
Open
34 tasks
@rousseldenis rousseldenis added this to the 12.0 milestone Feb 25, 2019
@pedrobaeza
Copy link
Member

Please sign the CLA

tbaden
tbaden reviewed Apr 21, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned from pedro please unify the string (see below), this way you only need to translate one term and can delete the other one.

everything else looks good to me

stock_picking_auto_create_lot/models/product.py Outdated Show resolved Hide resolved
stock_picking_auto_create_lot/models/stock_picking.py Show resolved Hide resolved
@oca-clabot
Copy link

Hey @meigallodixital,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

HaraldPanten
HaraldPanten approved these changes Sep 10, 2019
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. Tested on runbot 👍

@HaraldPanten
Copy link

Hi @meigallodixital ,

How's this PR? It's functionally working fine.

Thanks!

@rousseldenis
Copy link
Contributor

@meigallodixital

sergio-teruel
sergio-teruel approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments only

stock_picking_auto_create_lot/__manifest__.py Outdated Show resolved Hide resolved
stock_picking_auto_create_lot/i18n/es.po Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
[IMP] stock_picking_auto_create_lot: Change latest comments:
3b5a7c6 
- Promoted to Production/Stable
- Put maintainer
- Regenerate README
- Unify string
- Adapt translations accordingly
@pedrobaeza
Copy link
Member

I have pushed an extra commit for fixing pending comments, so we can

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-506-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 28, 2019
@OCA-git-bot
Merge PR #506 into 12.0
b87e3d9 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 3b5a7c6 into OCA:12.0 Nov 28, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b3e1edf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@tbaden tbaden tbaden left review comments

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
9 participants
@meigallodixital @oca-clabot @pedrobaeza @HaraldPanten @rousseldenis @OCA-git-bot @tbaden @sergio-teruel @oca-travis