Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] purchase_stock_picking_restrict_cancel #516

Merged
merged 7 commits into from
May 13, 2019
Merged

[12.0][MIG] purchase_stock_picking_restrict_cancel #516

merged 7 commits into from
May 13, 2019

Conversation

kittiu
Copy link
Member

@kittiu kittiu commented Apr 4, 2019 •
edited
Loading

Migration to v12 (WIP)

Dependencies

@kittiu kittiu force-pushed the 12.0-mig-purchase_stock_picking_restrict_cancel branch from 3f15f0d to e6be3b7 Compare April 9, 2019 11:26
@kittiu
Copy link
Member Author

kittiu commented Apr 9, 2019

This only need to rebase after its dependencies

@kittiu kittiu force-pushed the 12.0-mig-purchase_stock_picking_restrict_cancel branch 2 times, most recently from 09d2856 to 76c4936 Compare May 6, 2019 07:53
@rousseldenis rousseldenis added this to the 12.0 milestone May 6, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request May 6, 2019
Open
34 tasks
@kittiu
Copy link
Member Author

kittiu commented May 6, 2019

Rebased.
Now ready for review.

rousseldenis
rousseldenis approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

tbaden
tbaden suggested changes May 12, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM
just a minor change

purchase_stock_picking_restrict_cancel/__manifest__.py Outdated
{
"name": "Purchase Stock Picking Restrict Cancel",
"summary": "Restrict cancellation with Purchase.",
"version": "12.0.1.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the version: 12.0.1.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you!

@kittiu kittiu force-pushed the 12.0-mig-purchase_stock_picking_restrict_cancel branch from 76c4936 to 80b2cf2 Compare May 13, 2019 01:21
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis rousseldenis merged commit 4d543f1 into OCA:12.0 May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kittiu @OCA-git-bot @tbaden @rousseldenis @grindtildeath @oca-travis