Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][12.0] migrate product_expiry_simple #532

Closed
wants to merge 16 commits into from
Closed

[MIG][12.0] migrate product_expiry_simple #532

wants to merge 16 commits into from

Conversation

alexis-via
Copy link
Contributor

No description provided.

@rousseldenis rousseldenis added this to the 12.0 milestone Jun 7, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 7, 2019
Open
34 tasks
bealdav
bealdav suggested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_

bealdav
bealdav reviewed Nov 27, 2019
View reviewed changes
Copy link
Member

@bealdav bealdav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some remarks pushed as last commit

@bealdav bealdav force-pushed the 12-mig-product_expiry_simple branch from 74c108f to f7668b4 Compare April 22, 2020 12:03
@alexis-via alexis-via force-pushed the 12-mig-product_expiry_simple branch 2 times, most recently from 866cd50 to 16084bf Compare June 30, 2021 16:15
@alexis-via
Copy link
Contributor Author

Rebased. Should be ready for review/merge.

alexis-via and others added 16 commits November 19, 2021 22:21
@alexis-via
Add module product_expiry_simple
36fa1e6
@alexis-via
Small search view organisation improvement
bd8d196
@alexis-via
OCA coding standards
bbe9d4c
@alexis-via
Finish port of FEFO code to v10
675f158
@alexis-via
Add FR translation for product_expiry_simple
6c06300
@alexis-via
Improve module description in README
d8c9d06
@oca-transbot @alexis-via
OCA Transbot updated translations from Transifex
6e90bc7
@alan196 @alexis-via
make changes to migrate module to V11
f293454
@oca-travis @alexis-via
Update product_expiry_simple.pot
8c589df
@enriquemartin @alexis-via
product_expiry_simple: delete duplicate view
38e3e32
@OCA-git-bot @alexis-via
icon.png
2821065
@alexis-via
[MIG] product_expiry_simple from v11 to v12
9ebeb58
@alexis-via
Fix bug when both use_create_lots and use_existing_lots are enabled o…
37fb919 
…n the picking type

Update FR translation
@bealdav @alexis-via
FIX product_expiry_simple: key in manifest
eafc784
@alexis-via
product_expiry_simple: add myself as maintainer
1a376f2
@alexis-via
Upport fix for bug OCA#548 to v12
96dfcd0 
Fix bad decorator
@alexis-via
Copy link
Contributor Author

Travis is green, ready to merge

@alexis-via alexis-via mentioned this pull request Nov 26, 2021
Closed
@rousseldenis
Copy link
Contributor

@alexis-via IMHO, translations should be excluded as :

  • it should be done through weblate
  • it concerns another module

@alexis-via
Copy link
Contributor Author

@rousseldenis I don't understand your message about translation. I didn't do any translation in this module ; I only migrated it.

@rousseldenis
Copy link
Contributor

@rousseldenis I don't understand your message about translation. I didn't do any translation in this module ; I only migrated it.

This commit :

37fb919

But looking closer, they were broken. So, ok

@rousseldenis
Copy link
Contributor

@rousseldenis I don't understand your message about translation. I didn't do any translation in this module ; I only migrated it.

This commit :

37fb919

But looking closer, they were broken. So, ok

No, my preceding comment was ok. Remove translations for no_negative module from this.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 7, 2022
rousseldenis
rousseldenis reviewed Sep 7, 2022
View reviewed changes
stock_no_negative/i18n/fr.po
@@ -23,15 +23,15 @@ msgstr ""
#: code:addons/stock_no_negative/models/stock_quant.py:38
#, python-format
msgid " lot '%s'"
msgstr "lot%s"
msgstr "lot '%s'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via Could you remove changes in no_negative module from this PR ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups ! Well, this PR is closed now, so I don't think i'll fix it.

@github-actions github-actions bot closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@bealdav bealdav bealdav approved these changes

Assignees
No one assigned
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
8 participants
@alexis-via @rousseldenis @bealdav @oca-transbot @alan196 @oca-travis @enriquemartin @OCA-git-bot