Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] stock_pack_operation_auto_fill: Avoid auto fill qty_done when an extra_move has been created #546

Closed
wants to merge 1 commit into from
Closed

[FIX] stock_pack_operation_auto_fill: Avoid auto fill qty_done when an extra_move has been created #546

wants to merge 1 commit into from

Conversation

sergio-teruel
Copy link
Contributor

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 1, 2019
@pedrobaeza
Copy link
Member

Please fix tests according this change

@sergio-teruel sergio-teruel force-pushed the 11.0-PR-stock_pack_operation_auto_fill branch from ad2a6ab to 5f9a04c Compare July 2, 2019 07:25
@sergio-teruel
Copy link
Contributor Author

@rousseldenis @pedrobaeza Changes done

@sergio-teruel sergio-teruel force-pushed the 11.0-PR-stock_pack_operation_auto_fill branch from 5f9a04c to 9d520a4 Compare July 2, 2019 07:55
@rafaelbn
Copy link
Member

@pedrobaeza , @sergio-teruel made changes to 👍

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 16, 2019 •
edited
Loading

But he never notified us...

Let's merge this for having the patch.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 11.0-ocabot-merge-pr-546-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-546-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Rebased to 11.0-ocabot-merge-pr-546-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 11.0 in the meantime. Let me try again (no action is required from you).
Rebased to 11.0-ocabot-merge-pr-546-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot added a commit that referenced this pull request Aug 16, 2019
@OCA-git-bot
Merge PR #546 into 11.0
4951fcb 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4951fcb. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

@pedrobaeza
Copy link
Member

Is this needed in 12.0, @sergio-teruel ?

@pedrobaeza pedrobaeza deleted the 11.0-PR-stock_pack_operation_auto_fill branch August 16, 2019 21:23
@rafaelbn rafaelbn mentioned this pull request Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@rafaelbn rafaelbn rafaelbn approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sergio-teruel @pedrobaeza @rafaelbn @OCA-git-bot @rousseldenis