Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] delivery_package_default_shipping_weight: Migration to 14.0 #793

Merged
merged 8 commits into from
Sep 20, 2021
Merged

[MIG] delivery_package_default_shipping_weight: Migration to 14.0 #793

merged 8 commits into from
Sep 20, 2021

Conversation

dzungtran89
Copy link
Contributor

No description provided.

@dzungtran89 dzungtran89 mentioned this pull request Feb 27, 2021
Open
57 tasks
@rousseldenis rousseldenis added this to the 14.0 milestone Mar 1, 2021
rousseldenis
rousseldenis requested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. At least digits should be used.

delivery_package_default_shipping_weight/__manifest__.py Outdated Show resolved Hide resolved
delivery_package_default_shipping_weight/models/product_packaging.py Show resolved Hide resolved
delivery_package_default_shipping_weight/models/stock_quant_package.py Show resolved Hide resolved
@simahawk
Copy link
Contributor

@dzungtran89 ping

@dzungtran89
Copy link
Contributor Author

dzungtran89 commented Sep 14, 2021 •
edited
Loading

oups, somehow we missed this :(, thx for pinging me. We'll update it

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-delivery_package_default_shipping_weight branch 2 times, most recently from e53826a to 2f75b54 Compare September 15, 2021 05:35
@dzungtran89 dzungtran89 force-pushed the 14.0-mig-delivery_package_default_shipping_weight branch from 2f75b54 to 887588d Compare September 15, 2021 05:42
@dzungtran89
Copy link
Contributor Author

investigating on the travis build failed

@dzungtran89
Copy link
Contributor Author

fyi, the test case of this module is passed. Travis build is failed by the test case of module stock_picking_show_return, somehow wizard._onchange_picking_id() triggers a move's write. I'll create another PR for that module

@dzungtran89
Copy link
Contributor Author

I made a PR #891 for the module stock_picking_show_return

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-delivery_package_default_shipping_weight branch from 887588d to 71308b3 Compare September 20, 2021 05:21
@simahawk
Copy link
Contributor

@rousseldenis good for you?

rousseldenis
rousseldenis approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-793-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5b09cac into OCA:14.0 Sep 20, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c06609e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@dzungtran89 @simahawk @OCA-git-bot @rousseldenis @grindtildeath @guewen @oca-travis