Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] stock_move_assign_picking_hook: Migration to 14.0 #796

Merged

Conversation

phuctranfxvn
Copy link
Contributor

No description provided.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

"name": "Stock Move picking assignment hook",
"Summary": "Base module that adds an hook to override picking assignment on moves.",
"version": "14.0.1.1.0",
"development_status": "Alpha",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgrandguillaume Should the 14.0 modules stay in Alpha ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, can you help me recommend the correct development status of this module ? I am considering the module as stable. Let me know, thanks

Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsolanki-initos
Copy link
Contributor

Hi @phuctranerp can you please have a look at the minor changes so that we can merge this PR soon?

@phuctranfxvn phuctranfxvn force-pushed the 14.0-mig-stock_move_assign_picking_hook branch from a47a8fa to 707ad68 Compare April 8, 2021 07:32
@phuctranfxvn
Copy link
Contributor Author

Hi @dsolanki-initos

Thanks for reminding me, I have updated the PR.

@dsolanki-initos
Copy link
Contributor

@rousseldenis It would be great if you can merge this PR.

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-796-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e28e13e into OCA:14.0 Apr 30, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aedafc4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants