[14.0][MIG] stock_lock_lot: Migration to 14.0 #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the web client, if you type a new lot name and select "create" from the pop-up menu, the client calls the `create()` method with only the name attribute. All the other fields must be passed in the context. As a consequence, stock_lock_lot silently failed to block the lots because it didn't find the product. Fix it by looking for a product id in both the create values and the context.
* Log the reason when a lot is automatically locked This is useful whe custom submodules can lock lots for other reasons. Additional changes : fix the default value for the blocked checkbox (no big deal, it was overwritten anyway) ; migrate create to api v8 ; use AccessError when permissions are wrong. * Unreserve quants when blocking lots Users block lots when there is a problem with it (eg. quality issue), and it's important that no delivery is made when such a problem is found. So blocking is more important than reservations. So, ask for user confirmation when blocking, and then break the reservations. Includes translation into French
… on blocked Serial Numbers/lots." is set as True every time the DB is updated
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_lock_lot Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_lock_lot/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_lock_lot Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_lock_lot/
grindtildeath
approved these changes
Sep 17, 2021
| """ | ||
| _locked = product.categ_id.lot_default_locked | ||
| categ = product.categ_id.parent_id | ||
| while categ and not _locked: |
There was a problem hiding this comment.
IMO this could be improved with a search using parent_of
TDu
approved these changes
Oct 4, 2021
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at e2720ce. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration from 13.0 to 14.0