[14.0][MIG] delivery_total_weight_from_packaging: Migration to 14.0 #900
Conversation
| @@ -1,14 +1,14 @@ | |||
| # Copyright 2020 Camptocamp SA | |||
| # License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl) | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | |||
There was a problem hiding this comment.
Ok, I checked internally and this seems OK. @simahawk are you agree with this change?
There was a problem hiding this comment.
I don't get the reference to OCA/stock-logistics-warehouse#1256 🤔
There's no license mix here AFAIS (on v13 at least).
Also, "hiding" the license change in the same commit IMO it's not that good.
If there's no special / good reason to make it AGPL I'd roll back this change
There was a problem hiding this comment.
This PR has been rebased and updated. Thanks.
There was a problem hiding this comment.
Runbot was red, I restarted it to check the logs
Change the way the weight is computed on move, picking and package to include packaging weight instead of the weight of the product only.
hailangvn
force-pushed
the
14.0-mig-delivery_total_weight_from_packaging
branch
from
e20dcea to
9abaeb9
Compare
|
there's a problem w/ runbot not related to this PR. Maybe related to OCA/maintainer-quality-tools#697 /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 13c9bc4. Thanks a lot for contributing to OCA. ❤️ |
No description provided.