Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] stock_production_lot_active: Migration to 15.0 #976

Merged

Conversation

BT-dmontull
Copy link
Contributor

No description provided.

@BT-dmontull BT-dmontull mentioned this pull request Mar 4, 2022
66 tasks
@BT-dmontull
Copy link
Contributor Author

@StefanRijnhart could you merge this? I saw you merged the migration to 14.0: OCA/product-attribute#820

@rousseldenis
Copy link
Contributor

@StefanRijnhart could you merge this? I saw you merged the migration to 14.0: OCA/product-attribute#820

@BT-dmontull OCA rules for merge is to have at least 5 days and two approvals. Usually, it's fair to review other PR's too.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Contributor

/ocabot migration stock_production_lot_active

@StefanRijnhart
Copy link
Member

The tree view of this module is called stock_production_lot_search_view and the other way around. Can you fix that?

@BT-dmontull BT-dmontull force-pushed the 15.0-mig-stock_production_lot_active branch from ae66ecb to af6b62a Compare March 10, 2022 08:41
@BT-dmontull
Copy link
Contributor Author

@StefanRijnhart I fixed It, but now doesn't pass runbot test. And It's because yesterday rsync change version in ubuntu repositories (from rsync_3.1.3-8ubuntu0.1_amd64.deb to rsync_3.1.3-8ubuntu0.2_amd64.deb)
what should i do to fix it?
Thanks

@rousseldenis
Copy link
Contributor

@StefanRijnhart I fixed It, but now doesn't pass runbot test. And It's because yesterday rsync change version in ubuntu repositories (from rsync_3.1.3-8ubuntu0.1_amd64.deb to rsync_3.1.3-8ubuntu0.2_amd64.deb) what should i do to fix it? Thanks

I've created an issue here : sbidoul/runboat#48

We need to wait.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! The runboat error should not be blocking.

@rousseldenis
Copy link
Contributor

Thanks for the update! The runboat error should not be blocking.

We can launch the merge for sure.

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-976-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c9236c3 into OCA:15.0 Mar 10, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b50f0ee. Thanks a lot for contributing to OCA. ❤️

sergio-teruel pushed a commit to Tecnativa/stock-logistics-workflow that referenced this pull request Jan 25, 2023
Signed-off-by rousseldenis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants