Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] survey_crm_generation: support all answers for lead description #100

Merged

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Nov 7, 2023

Make use of survey_result_mail answers builder to get rich format answers of all the supported types.

TT40979 cc @Tecnativa TT40979

please review @pedrobaeza @pilarvargas-tecnativa

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 7, 2023
@pedrobaeza
Copy link
Member

And what about #88 ?

@chienandalu
Copy link
Member Author

And what about #88 ?

Yes, that would be the idea. To pull that dependency so we can use a common method, but I should refactor it a little bit

@pedrobaeza
Copy link
Member

OK, go ahead with it.

@chienandalu chienandalu force-pushed the 15.0-fix-survey_crm_generation-answer_type branch 2 times, most recently from 6d3566d to 2ef8ee5 Compare November 7, 2023 14:53
@chienandalu chienandalu force-pushed the 15.0-fix-survey_crm_generation-answer_type branch from 2ef8ee5 to a37c27b Compare November 16, 2023 14:31
@chienandalu chienandalu marked this pull request as ready for review November 16, 2023 14:31
@chienandalu chienandalu force-pushed the 15.0-fix-survey_crm_generation-answer_type branch 2 times, most recently from 6034a7e to 57909af Compare November 16, 2023 14:37
@chienandalu chienandalu force-pushed the 15.0-fix-survey_crm_generation-answer_type branch from 57909af to 542c8fe Compare November 30, 2023 14:44
@chienandalu
Copy link
Member Author

Please re-review @pilarvargas-tecnativa @pedrobaeza

Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, thanks :)

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-100-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ae63502 into OCA:15.0 Feb 8, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 783584e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants