Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] survey_question_type_binary: Migration to 16.0 #121

Merged
merged 5 commits into from
May 6, 2024

Conversation

jguenat
Copy link
Member

@jguenat jguenat commented May 2, 2024

Migration from 14.0 and a fix
If fix accepted I'll backport it to 14.0

zamberjo and others added 5 commits May 2, 2024 09:16
Issue: no answer was created if question not filled. If filled is was marked as Skipped
- Create a Skipped answer when the binary question is not filled
- If filled, put the file name is the Answer or the number of files in case of binary_multi
@pedrobaeza
Copy link
Member

/ocabot migration survey_question_type_binary

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 2, 2024
4 tasks
@jguenat
Copy link
Member Author

jguenat commented May 3, 2024

HI @zamberjo
Do you have time to review this migration / fix ?
Let me know if you need help elsewhere in OCA
Thanks

Copy link
Member

@zamberjo zamberjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-121-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aaf8b4d into OCA:16.0 May 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4c20c01. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants