[11.0][IMP] hr_timesheet_sheet: ease extensions #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mreficent may I ask you to have a look at this PR ? |
tafaRU
reviewed
Sep 11, 2018
tafaRU
approved these changes
Sep 11, 2018
JordiBForgeFlow
approved these changes
Sep 11, 2018
pedrobaeza
reviewed
Sep 11, 2018
| def _check_state(self): | ||
| if self._context.get('skip_check_state'): |
There was a problem hiding this comment.
Use self.env.context instead
There was a problem hiding this comment.
That variable is internal and might change, and Odoo itself deprecated it:
pedrobaeza
approved these changes
Sep 11, 2018
alexey-pelykh
pushed a commit
to brainbeanapps/timesheet
that referenced
this pull request
Nov 9, 2018
flachica
pushed a commit
to flachica/timesheet
that referenced
this pull request
Mar 2, 2020
MiquelRForgeFlow
pushed a commit
to ForgeFlow/hr-timesheet
that referenced
this pull request
Apr 6, 2020
MiquelRForgeFlow
pushed a commit
to ForgeFlow/hr-timesheet
that referenced
this pull request
Apr 6, 2020
pniederlag
pushed a commit
to datenbetrieb/timesheet
that referenced
this pull request
Dec 26, 2020
schhatbar-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Mar 9, 2021
yajo
pushed a commit
to moduon/timesheet
that referenced
this pull request
Mar 30, 2022
dochse
pushed a commit
to dochse/timesheet
that referenced
this pull request
Apr 21, 2022
dochse
pushed a commit
to dochse/timesheet
that referenced
this pull request
Apr 22, 2022
benwillig
pushed a commit
to resultrum/timesheet
that referenced
this pull request
Sep 1, 2022
bizzappdev
pushed a commit
to bizzappdev/timesheet
that referenced
this pull request
Nov 5, 2022
bizzappdev
pushed a commit
to BizzAppDev-Systems/timesheet
that referenced
this pull request
Feb 20, 2023
tarteo
pushed a commit
to tarteo/timesheet
that referenced
this pull request
Feb 28, 2023
dreispt
pushed a commit
to ursais/timesheet
that referenced
this pull request
Jan 21, 2024
SodexisTeam
pushed a commit
to sodexis/timesheet
that referenced
this pull request
Jun 10, 2024
vnikolayev1
pushed a commit
to vnikolayev1/timesheet
that referenced
this pull request
Aug 15, 2024
SodexisTeam
pushed a commit
to sodexis/timesheet
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module
hr_timesheet_sheetimplements a constraint on the timesheet lines: they cannot be modified in case the timesheet sheet is approved. However in some our customizations, we need to relax a bit this constraint, allowing in some particular cases to write on a timesheet line, even when the timesheet sheet was already approved.This is a proposal for letting the
def _check_state()method be skipped.Also an extra hook method is added, to let the customization modules decide whether
def _check_state()should be executed or not.This way the module will be easier to be extended.