Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] hr_timesheet_sheet: fix amount calculation issues + code simplification #211

Merged
merged 8 commits into from
Mar 25, 2019
Merged

[12.0][IMP] hr_timesheet_sheet: fix amount calculation issues + code simplification #211

merged 8 commits into from
Mar 25, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 20, 2019

Porting of #207 to V12

@astirpe astirpe mentioned this pull request Mar 20, 2019
Merged
@alexey-pelykh
Copy link
Contributor

@astirpe many thanks for the porting!

@astirpe
Copy link
Member Author

astirpe commented Mar 21, 2019 •
edited
Loading

Commit 3bb749c 8cfea2f makes the matrix lines created with the batch create. This should speeds up the refresh of the summary tab when any onchange is done in the details tab.

@alexey-pelykh
Copy link
Contributor

@aheficent what would you say about this?

@alexey-pelykh
Copy link
Contributor

@mreficent @pedrobaeza this one is forward-port of recently-merged PR

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alexey-pelykh
Copy link
Contributor

@pedrobaeza please hit the button 👍

@pedrobaeza
Copy link
Member

I'm the blind button clicker 😋

@pedrobaeza pedrobaeza merged commit 6dfe2ef into OCA:12.0 Mar 25, 2019
@alexey-pelykh
Copy link
Contributor

We guide you! )

@astirpe astirpe deleted the 12_imp_hr_timesheet_sheet branch March 25, 2019 12:16
flachica pushed a commit to flachica/timesheet that referenced this pull request Mar 2, 2020
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
a1cbbce 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
MiquelRForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Apr 6, 2020
@astirpe @MiquelRForgeFlow
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
70003c5 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
MiquelRForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Apr 6, 2020
@astirpe @MiquelRForgeFlow
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
96a1b84 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
pniederlag pushed a commit to datenbetrieb/timesheet that referenced this pull request Dec 26, 2020
@astirpe @pniederlag
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
8368951 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
schhatbar-initos pushed a commit to initOS/timesheet that referenced this pull request Mar 9, 2021
@astirpe @schhatbar-initos
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
7685903 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
yajo pushed a commit to moduon/timesheet that referenced this pull request Mar 30, 2022
@astirpe @yajo
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
783be93 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
dochse pushed a commit to dochse/timesheet that referenced this pull request Apr 21, 2022
@astirpe @dochse
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
aa7a1e6 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
dochse pushed a commit to dochse/timesheet that referenced this pull request Apr 22, 2022
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
b7e88dd 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
benwillig pushed a commit to resultrum/timesheet that referenced this pull request Sep 1, 2022
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
d9df3f4 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
bizzappdev pushed a commit to bizzappdev/timesheet that referenced this pull request Nov 5, 2022
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
b44b919 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
bizzappdev pushed a commit to BizzAppDev-Systems/timesheet that referenced this pull request Feb 20, 2023
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
ec00d05 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
tarteo pushed a commit to tarteo/timesheet that referenced this pull request Feb 28, 2023
@astirpe @tarteo
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
50ae27e 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
dreispt pushed a commit to ursais/timesheet that referenced this pull request Jan 21, 2024
@astirpe @dreispt
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
14fb504 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
@dreispt dreispt mentioned this pull request Jan 21, 2024
Closed
SodexisTeam pushed a commit to sodexis/timesheet that referenced this pull request Jun 10, 2024
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
065fc3a 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
vnikolayev1 pushed a commit to vnikolayev1/timesheet that referenced this pull request Aug 15, 2024
@astirpe
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
3d0bc5b 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
SodexisTeam pushed a commit to sodexis/timesheet that referenced this pull request Oct 18, 2024
@astirpe @Vijaiy-Selvaraj
[IMP] hr_timesheet_sheet: fix amount calculation issues + code simpli…
c1b11e3 
…fication (OCA#211)

* [IMP] Fix amount calculation issues + code simplification

* [FIX] Fix employee_id related stuff

* [IMP] Ease customizations of message_subscribe_users

* [IMP] List view easier to read

* [IMP] Extra code simplification

* [IMP] Make use of batch create

* [FIX] Update company when onchange employee_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@astirpe @alexey-pelykh @OCA-git-bot @pedrobaeza @MiquelRForgeFlow