Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][FIX] hr_timesheet_sheet: subscribe user when confirm #227

Merged
merged 3 commits into from
Apr 3, 2019
Merged

[12.0][FIX] hr_timesheet_sheet: subscribe user when confirm #227

merged 3 commits into from
Apr 3, 2019

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 29, 2019

This PR fixes the following:

Set a manager for an employee.
Confirm the timesheet of the employee.

Result:
AttributeError: 'hr_timesheet.sheet' object has no attribute 'message_subscribe_users'

This PR also includes the porting of #224 to V12.

Copy link
Contributor

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx, this fixed an issue I had!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit bb194a6 into OCA:12.0 Apr 3, 2019
@astirpe astirpe deleted the 12_fix_hr_timesheet_sheet branch April 3, 2019 08:03
flachica pushed a commit to flachica/timesheet that referenced this pull request Mar 2, 2020
MiquelRForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Apr 6, 2020
MiquelRForgeFlow pushed a commit to ForgeFlow/hr-timesheet that referenced this pull request Apr 6, 2020
pniederlag pushed a commit to datenbetrieb/timesheet that referenced this pull request Dec 26, 2020
yajo pushed a commit to moduon/timesheet that referenced this pull request Mar 30, 2022
dochse pushed a commit to dochse/timesheet that referenced this pull request Apr 21, 2022
dochse pushed a commit to dochse/timesheet that referenced this pull request Apr 22, 2022
benwillig pushed a commit to resultrum/timesheet that referenced this pull request Sep 1, 2022
bizzappdev pushed a commit to bizzappdev/timesheet that referenced this pull request Nov 5, 2022
bizzappdev pushed a commit to BizzAppDev-Systems/timesheet that referenced this pull request Feb 20, 2023
tarteo pushed a commit to tarteo/timesheet that referenced this pull request Feb 28, 2023
dreispt pushed a commit to ursais/timesheet that referenced this pull request Jan 21, 2024
SodexisTeam pushed a commit to sodexis/timesheet that referenced this pull request Jun 10, 2024
vnikolayev1 pushed a commit to vnikolayev1/timesheet that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants