Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] hr_timesheet_task_required #478

Merged
merged 51 commits into from
Jun 29, 2022

Conversation

houssine78
Copy link

No description provided.

adrienpeiffer and others added 30 commits March 10, 2022 14:06
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-timesheet-12.0/hr-timesheet-12.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-12-0/hr-timesheet-12-0-hr_timesheet_task_required/
Currently translated at 100.0% (8 of 8 strings)

Translation: hr-timesheet-12.0/hr-timesheet-12.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-12-0/hr-timesheet-12-0-hr_timesheet_task_required/nl_NL/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_required/
Currently translated at 88.9% (8 of 9 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_required/de/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_required/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_required/
bosd and others added 6 commits March 10, 2022 14:06
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/nl_NL/
Currently translated at 66.6% (6 of 9 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/
Currently translated at 100.0% (12 of 12 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_required
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_required/es/
@oca-clabot
Copy link

Hey @houssine78, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@houssine78 houssine78 mentioned this pull request Mar 10, 2022
17 tasks
@houssine78
Copy link
Author

@sbidoul I get an error on runboat which seems to unralated to the PR

image

@pedrobaeza
Copy link
Member

See sbidoul/runboat#48

@houssine78 houssine78 force-pushed the 15.0-mig-hr_timesheet_task_required branch from 074f69d to c652178 Compare March 10, 2022 14:20
@houssine78
Copy link
Author

Hi @benwillig seems you're marked as you haven't signed the OCA CLA

@yankinmax
Copy link

@houssine78 can you pls give an access to your timesheet repo? I want to update this PR with the fix. THX
or just update it with the fix:

<record id="project_invoice_form" model="ir.ui.view">
    <field name="name">project.project.view.form</field>
    <field name="model">project.project</field>
    <field name="inherit_id" ref="hr_timesheet.project_invoice_form" />
    <field name="arch" type="xml">
        <xpath expr="//div[@id='timesheet_settings']" position="after">
            <div
                class="col-lg-6 o_setting_box"
                id="timesheet_task_settings"
                attrs="{'invisible': [('allow_timesheets', '=', False)]}"
            >
                <div class="o_setting_left_pane">
                    <field name="is_timesheet_task_required" class="oe_inline" />
                </div>
                <div class="o_setting_right_pane">
                    <label for="is_timesheet_task_required" />
                    <div class="text-muted">
                        Set tasks on timesheet as a mandatory field
                    </div>
                </div>
            </div>
        </xpath>
    </field>
</record>

And also, don't forget to change version numbers across the files from 14.0 to 15.0, and 14-0 to 15-0

@houssine78
Copy link
Author

Hi @yankinmax,
I just give you the access.

Thank you

@yankinmax yankinmax force-pushed the 15.0-mig-hr_timesheet_task_required branch from 0febe6e to b89376f Compare June 29, 2022 06:56
@yankinmax
Copy link

@alexey-pelykh

@alexey-pelykh alexey-pelykh changed the title [15.0] [PORT] hr timesheet task required [15.0][MIG] hr_timesheet_task_required Jun 29, 2022
@alexey-pelykh
Copy link
Contributor

/ocabot migration hr_timesheet_task_required
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 29, 2022
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-478-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d7748f8 into OCA:15.0 Jun 29, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 907343e. Thanks a lot for contributing to OCA. ❤️

@houssine78
Copy link
Author

thank you @yankinmax

@yankinmax
Copy link

thank you @yankinmax

same to you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.