Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_timesheet_line_exclude #515

Merged
merged 26 commits into from
Oct 1, 2022
Merged

[15.0][MIG] sale_timesheet_line_exclude #515

merged 26 commits into from
Oct 1, 2022

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Aug 12, 2022

#503 has some failing tests.
There were also a lot of odoo changes between version 13, 14 and 15, so fixing these caused a little bigger refactoring.

alexey-pelykh and others added 26 commits July 1, 2022 17:36
* [FIX] sale_timesheet_line_exclude: fix manifest
* [FIX] sale_timesheet_task_exclude: fix manifest
Currently translated at 20.0% (1 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/de/
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/fr/
@CRogos CRogos mentioned this pull request Aug 22, 2022
17 tasks
@CRogos
Copy link
Contributor Author

CRogos commented Sep 5, 2022

@alexey-pelykh , @elvise , @francesco-ooops would you also like to review my v15 migration?

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

Copy link

@elvise elvise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor Author

CRogos commented Sep 16, 2022

@alexey-pelykh could you have a look and when merged also close #503

@@ -4,7 +4,7 @@

{
"name": "Sales Timesheet: exclude Timesheet Line from Sale Order",
"version": "14.0.1.0.0",
"version": "15.0.1.0.0",
"category": "Sales",
"website": "https://github.com/OCA/timesheet",
"author": "CorporateHub, " "Odoo Community Association (OCA)",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "CorporateHub, " "Odoo Community Association (OCA)",
"author": "CorporateHub, Odoo Community Association (OCA)",

That line could be cleaned up a bit.

@dreispt
Copy link
Member

dreispt commented Oct 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-515-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-515-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7cc8490 into OCA:15.0 Oct 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 19071fd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.