Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_timesheet_line_exclude #515

Merged
merged 26 commits into from
Oct 1, 2022
Merged

[15.0][MIG] sale_timesheet_line_exclude #515

merged 26 commits into from
Oct 1, 2022

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Aug 12, 2022

#503 has some failing tests.
There were also a lot of odoo changes between version 13, 14 and 15, so fixing these caused a little bigger refactoring.

alexey-pelykh and others added 26 commits July 1, 2022 17:36
@alexey-pelykh @Freni-OSI
[ADD] sale_timesheet_line_exclude: exclude Timesheet Line from Sale O…
6ac6d37 
…rder
@OCA-git-bot @Freni-OSI
[UPD] README.rst
a4a49f3
@OCA-git-bot @Freni-OSI
[ADD] icon.png
72a3618
@oca-travis @Freni-OSI
[UPD] Update sale_timesheet_line_exclude.pot
4faba4c
@alexey-pelykh @Freni-OSI
[12.0][FIX] Manifest fixes (#255)
59a6fcb 
* [FIX] sale_timesheet_line_exclude: fix manifest
* [FIX] sale_timesheet_task_exclude: fix manifest
@marylla @Freni-OSI
Added translation using Weblate (German)
0010024
@marylla @Freni-OSI
Translated using Weblate (German)
f8d88ec 
Currently translated at 20.0% (1 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/de/
@marylla @Freni-OSI
Translated using Weblate (German)
7b30ca2 
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/de/
@OCA-git-bot @Freni-OSI
[UPD] README.rst
b37db14
@oca-travis @Freni-OSI
[UPD] Update sale_timesheet_line_exclude.pot
e5ff643
@oca-transbot @Freni-OSI
Update translation files
020da58 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/
@josepmy @Freni-OSI
Added translation using Weblate (Spanish)
e39fb12
@josepmy @Freni-OSI
Translated using Weblate (Spanish)
a3cdccf 
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/es/
@alexey-pelykh @Freni-OSI
[UPD] Brainbean Apps => CorporateHub
ad09f50
@OCA-git-bot @Freni-OSI
[UPD] README.rst
10c3370
@dreispt @Freni-OSI
[FIX] sale_timesheet_line_exclude: user friendly Non-billable label
cbc8d5b
@oca-transbot @Freni-OSI
Update translation files
bd4a465 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/
@OCA-git-bot @Freni-OSI
[UPD] README.rst
86b35c0
@ypapouin @Freni-OSI
Added translation using Weblate (French)
4c5033c
@ypapouin @Freni-OSI
Translated using Weblate (French)
f3f1fda 
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-12.0/timesheet-12.0-sale_timesheet_line_exclude
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-sale_timesheet_line_exclude/fr/
@Du-ma @Freni-OSI
[IMP] sale_timesheet_line_exclude: black, isort, prettier
2be5711
@Du-ma @Freni-OSI
[MIG] sale_timesheet_line_exclude: migration to 13.0
3cb52e8
@oca-travis @Freni-OSI
[UPD] Update sale_timesheet_line_exclude.pot
1efd195
@OCA-git-bot @Freni-OSI
[UPD] README.rst
17d4d59
@dantiller2 @Freni-OSI
[MIG] sale_timesheet_line_exclude: Migration to 14.0
82a0b97
@Freni-OSI
[15.0][MIG] sale_timesheet_line_exclude
6ee49ce
@CRogos CRogos mentioned this pull request Aug 22, 2022
Open
17 tasks
@CRogos
Copy link
Contributor Author

CRogos commented Sep 5, 2022

@alexey-pelykh , @elvise , @francesco-ooops would you also like to review my v15 migration?

francesco-ooops
francesco-ooops approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

elvise
elvise approved these changes Sep 6, 2022
View reviewed changes
Copy link

@elvise elvise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor Author

CRogos commented Sep 16, 2022

@alexey-pelykh could you have a look and when merged also close #503

vincent-hatakeyama
vincent-hatakeyama reviewed Sep 29, 2022
View reviewed changes
sale_timesheet_line_exclude/__manifest__.py
@@ -4,7 +4,7 @@

{
"name": "Sales Timesheet: exclude Timesheet Line from Sale Order",
"version": "14.0.1.0.0",
"version": "15.0.1.0.0",
"category": "Sales",
"website": "https://github.com/OCA/timesheet",
"author": "CorporateHub, " "Odoo Community Association (OCA)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "CorporateHub, " "Odoo Community Association (OCA)",
"author": "CorporateHub, Odoo Community Association (OCA)",

That line could be cleaned up a bit.

@dreispt
Copy link
Member

dreispt commented Oct 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-515-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2022
@OCA-git-bot
Merge PR #515 into 15.0
30148e9 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-515-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7cc8490 into OCA:15.0 Oct 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 19071fd. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-hatakeyama vincent-hatakeyama vincent-hatakeyama left review comments

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@elvise elvise elvise approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.