Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] hr_timesheet_activity_begin_end #517

Merged
merged 45 commits into from
Nov 10, 2022
Merged

[15.0][MIG] hr_timesheet_activity_begin_end #517

merged 45 commits into from
Nov 10, 2022

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Aug 23, 2022

contains changes of #507 and depends on hr_timesheet_sheet

@CRogos CRogos mentioned this pull request Aug 23, 2022
17 tasks
@CRogos
Copy link
Contributor Author

CRogos commented Sep 21, 2022

@schhatbar-initos @bosd could you have a look at this? You were involved in the v14 migration.

@manuelcalerosolis
Copy link

Trying to download the module gives me this error.

Auto-merging setup/_metapackage/setup.py507)
CONFLICT (content): Merge conflict in setup/_metapackage/setup.py
Automatic merge failed; fix conflicts and then commit the result.

setup/_metapackage/setup.py

install_requires=[
    'odoo-addon-hr_timesheet_task_domain>=15.0dev,<15.1dev',
    'odoo-addon-hr_timesheet_task_required>=15.0dev,<15.1dev',
    'odoo14-addon-hr_timesheet_activity_begin_end',
    'odoo14-addon-hr_timesheet_begin_end',
    'odoo14-addon-hr_timesheet_analysis',
    'odoo14-addon-hr_timesheet_sheet_begin_end',
],
classifiers=[
    'Programming Language :: Python',

@CRogos
Copy link
Contributor Author

CRogos commented Oct 10, 2022

I have rebased the branch, please try again.

@manuelcalerosolis
Copy link

Now is ok!

Thanks

@CRogos
Copy link
Contributor Author

CRogos commented Oct 21, 2022

I've rebased and implemented the split/rename of hr_timesheet_activity_begin_end in hr_timesheet_begin_end and hr_timesheet_sheet_begin_end.

  graph TD;
subgraph Active
      A["hr_timesheet"]
      
      A-->B["hr_timesheet_begin_end"];
      A-->C["hr_timesheet_sheet"];
      C-->D["hr_timesheet_sheet_begin_end"];
      B-->D;
end
      subgraph Depricated
          D-->E["hr_timesheet_activity_begin_end"];
      end
Loading

guewen and others added 22 commits November 9, 2022 15:53
Currently translated at 100.0% (6 of 6 strings)

Translation: hr-timesheet-10.0/hr-timesheet-10.0-hr_timesheet_activity_begin_end
Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-10-0/hr-timesheet-10-0-hr_timesheet_activity_begin_end/it/
Currently translated at 100.0% (6 of 6 strings)

Translation: hr-timesheet-10.0/hr-timesheet-10.0-hr_timesheet_activity_begin_end
Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-10-0/hr-timesheet-10-0-hr_timesheet_activity_begin_end/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_activity_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_activity_begin_end/
Currently translated at 100.0% (6 of 6 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_activity_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_activity_begin_end/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_activity_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_activity_begin_end/
OCA-git-bot added a commit that referenced this pull request Nov 9, 2022
Signed-off-by nimarosa
@nimarosa
Copy link

nimarosa commented Nov 9, 2022

/ocabot migration hr_timesheet_activity_begin_end

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 9, 2022
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-517-by-nimarosa-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 9, 2022
Signed-off-by nimarosa
sbidoul
sbidoul previously requested changes Nov 9, 2022
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A technical remark, raised by the bot monitoring.

@nimarosa
Copy link

nimarosa commented Nov 9, 2022

@CRogos please make the changes suggested by @sbidoul so we can try the merge again

@CRogos CRogos requested a review from sbidoul November 10, 2022 09:18
@CRogos
Copy link
Contributor Author

CRogos commented Nov 10, 2022

Ok I think I've fixed the links. Is my change causing now the build error? From the logs I assume a github connection issue?

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green now, thanks. Please retry the merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@nimarosa
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-517-by-nimarosa-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 419138a into OCA:15.0 Nov 10, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 85519d6. Thanks a lot for contributing to OCA. ❤️

@EmilioPascual
Copy link

I have just added rename module to apriory in openupgrade OCA/OpenUpgrade#4340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.