-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] hr_timesheet_activity_begin_end #517
[15.0][MIG] hr_timesheet_activity_begin_end #517
Conversation
@schhatbar-initos @bosd could you have a look at this? You were involved in the v14 migration. |
Trying to download the module gives me this error. Auto-merging setup/_metapackage/setup.py507) setup/_metapackage/setup.py
|
I have rebased the branch, please try again. |
Now is ok! Thanks |
I've rebased and implemented the split/rename of hr_timesheet_activity_begin_end in hr_timesheet_begin_end and hr_timesheet_sheet_begin_end. graph TD;
subgraph Active
A["hr_timesheet"]
A-->B["hr_timesheet_begin_end"];
A-->C["hr_timesheet_sheet"];
C-->D["hr_timesheet_sheet_begin_end"];
B-->D;
end
subgraph Depricated
D-->E["hr_timesheet_activity_begin_end"];
end
|
Currently translated at 100.0% (6 of 6 strings) Translation: hr-timesheet-10.0/hr-timesheet-10.0-hr_timesheet_activity_begin_end Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-10-0/hr-timesheet-10-0-hr_timesheet_activity_begin_end/it/
Currently translated at 100.0% (6 of 6 strings) Translation: hr-timesheet-10.0/hr-timesheet-10.0-hr_timesheet_activity_begin_end Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-10-0/hr-timesheet-10-0-hr_timesheet_activity_begin_end/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_activity_begin_end Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_activity_begin_end/
Currently translated at 100.0% (6 of 6 strings) Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_activity_begin_end Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_activity_begin_end/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_activity_begin_end Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_activity_begin_end/
/ocabot migration hr_timesheet_activity_begin_end |
This PR has the |
On my way to merge this fine PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A technical remark, raised by the bot monitoring.
setup/hr_timesheet_sheet_begin_end/odoo/addons/hr_timesheet_sheet_begin_end
Show resolved
Hide resolved
Ok I think I've fixed the links. Is my change causing now the build error? From the logs I assume a github connection issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green now, thanks. Please retry the merge
This PR has the |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 85519d6. Thanks a lot for contributing to OCA. ❤️ |
I have just added rename module to apriory in openupgrade OCA/OpenUpgrade#4340 |
contains changes of #507 and depends on hr_timesheet_sheet