[15.0][MIG] crm_timesheet: Migration to version 15.0 #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudLaf
force-pushed
the
15.0-mig-crm_timesheet
branch
from
31a02f9
to
f11157e
Compare
This addon assumed one will always fill the analytic account before the project, but current behavior does not let you choose a project outside current analytic account, which in practice means you can never change the project if `analytic_account_id` field is hidden (as it happens in other addons such as `project_issue_timesheet_time_control`). Now, if you choose a project it will fill the analytic account, and also the other way around, so why bother about the domains?
As now hr_timesheet bases all their functionality on projects, there's no sense to keep the old behavior linking crm.lead times to analytic account instead of projects, so I have changed this, making easier the associated logic (which, in the other hand, was not fully correct previously).
Currently translated at 100.0% (4 of 4 strings) Translation: hr-timesheet-11.0/hr-timesheet-11.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-11-0/hr-timesheet-11-0-crm_timesheet/it/
* Limit timesheet field addition in view to authorized users * Use proper view in lead embedded timesheet page * Don't show lead field in embedded timesheet page
Currently translated at 100.0% (4 of 4 strings) Translation: timesheet-12.0/timesheet-12.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-crm_timesheet/de/
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
Imagine this scenario: 1. In tab 1 of the browser, you have opened lead 1. 2. In tab 2 of the browser, you have opened lead 2. 3. You go to tab 1 and start a timer. 4. Work, work, work... 5. You go to tab 2 and start a timer, stopping that of lead 1. 6. Work, work, work... 7. You go to tab 1 and see that timer as running (it is not, but you didn't refresh). You hit stop. Before this commit, it just seemed like the timer was actually stopped. What did happen behind the scenes is that your view was refreshed, but no timer was touched fortunately. After this commit, you get a message telling you that there's no timer to stop and that your browser is most likely out of sync. This mimics the behavior previously found when doing the same, but directly in the AAL. Now it's present in leads too.
Models related to timesheet time controls now inherit from a mixin that adds most needed logic automatically. This requires the changes introduced in OCA/project#596.
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-12.0/timesheet-12.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-crm_timesheet/es/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-12.0/timesheet-12.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-crm_timesheet/pt/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-12.0/timesheet-12.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-crm_timesheet/pt_BR/
- README and manifest adapted - Views changed
Currently translated at 57.1% (4 of 7 strings) Translation: timesheet-13.0/timesheet-13.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-13-0/timesheet-13-0-crm_timesheet/nl/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-14.0/timesheet-14.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-crm_timesheet/it/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-14.0/timesheet-14.0-crm_timesheet Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-crm_timesheet/pt_BR/
pedrobaeza
force-pushed
the
15.0-mig-crm_timesheet
branch
from
f11157e
to
4b7f06f
Compare
|
/ocabot migration crm_timesheet |
pedrobaeza
force-pushed
the
15.0-mig-crm_timesheet
branch
from
4b7f06f
to
672ccfa
Compare
pedrobaeza
approved these changes
Nov 27, 2022
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 6155130. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc TT40290
@pedrobaeza please review.