Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_timesheet_begin_end: Migration to 17.0 #632

Merged
merged 8 commits into from
Mar 2, 2024
Merged

[17.0][MIG] hr_timesheet_begin_end: Migration to 17.0 #632

merged 8 commits into from
Mar 2, 2024

Conversation

NICO-SOLUTIONS
Copy link
Member

standard migration to 17.0

@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review February 4, 2024 10:47
@NICO-SOLUTIONS NICO-SOLUTIONS mentioned this pull request Feb 4, 2024
Open
12 tasks
@MohamedOsman7
Copy link

Everything looks good to me. However, i noticed a warning in the test, that should be addressed.

"2024-02-04 10:45:04,497 237 WARNING odoo py.warnings: /opt/odoo/odoo/addons/base/models/ir_module.py:178: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, hr_timesheet_begin_end can just have a UTF8 description with not need for a declaration."

@NICO-SOLUTIONS
Copy link
Member Author

This will be fixed by pre commit when adjusted to not create encoding in Index file!

CRogos
CRogos reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the copier template. A rebase should solve the warning.
The rest looks good to me.

CRogos and others added 8 commits February 27, 2024 12:01
@CRogos @NICO-SOLUTIONS
[MIG] hr_timesheet_activity_begin_end: Update to 15.0
3009e32
@NICO-SOLUTIONS
[IMP] hr_timesheet_begin_end: black, isort, prettier
666f9bd
@NICO-SOLUTIONS
[MIG] hr_timesheet_begin_end: Migration to 16.0
be880b0
@NICO-SOLUTIONS
[IMP] hr_timesheet_begin_end: missing form fields
a8285b1 
[UPD] Update hr_timesheet_begin_end.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_begin_end/

[UPD] README.rst
@adrianojprado @NICO-SOLUTIONS
Added translation using Weblate (Portuguese (Brazil))
2f243b9 
Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (6 of 6 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_begin_end/pt_BR/
@pere-aquarian @NICO-SOLUTIONS
Added translation using Weblate (Catalan)
eb20427 
Translated using Weblate (Catalan)

Currently translated at 100.0% (6 of 6 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_begin_end
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_begin_end/ca/
@NICO-SOLUTIONS
[IMP] hr_timesheet_begin_end: pre-commit auto fixes
baff2db
@NICO-SOLUTIONS
[MIG] hr_timesheet_begin_end: Migration to 17.0
fca4a71
@NICO-SOLUTIONS
Copy link
Member Author

@CRogos thanks for updating the copier. rebased and ready for further review...

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Mar 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-632-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 2, 2024
@OCA-git-bot
Merge PR #632 into 17.0
a5147c6 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-632-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a95a928 into OCA:17.0 Mar 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 72d79ae. Thanks a lot for contributing to OCA. ❤️

@NICO-SOLUTIONS NICO-SOLUTIONS deleted the 17.0-mig-hr_timesheet_begin_end branch March 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogos CRogos CRogos approved these changes

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NICO-SOLUTIONS @MohamedOsman7 @OCA-git-bot @dreispt @CRogos @adrianojprado @pere-aquarian