Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_timesheet_task_stage: Migration to 17.0 #701

Merged

Conversation

RogerSans
Copy link

@RogerSans RogerSans commented Jul 29, 2024

Supersede = #650
Standard migration
T-6450

@HaraldPanten
@ValentinVinagre
@luis-ron

alexey-pelykh and others added 30 commits July 29, 2024 13:00
Currently translated at 100.0% (8 of 8 strings)

Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_stage/de/
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
	modificado:     hr_timesheet_task_stage/models/account_analytic_line.py
	modificado:     hr_timesheet_task_stage/tests/test_hr_timesheet_task_stage.py
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-13.0/timesheet-13.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-13-0/timesheet-13-0-hr_timesheet_task_stage/
Currently translated at 77.8% (7 of 9 strings)

Translation: timesheet-13.0/timesheet-13.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-13-0/timesheet-13-0-hr_timesheet_task_stage/he_IL/
Currently translated at 100.0% (12 of 12 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_stage/sv/
Currently translated at 91.6% (11 of 12 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_stage/fr/
Since v14, string attribute of elements are directly shown in the views
as text instead of being a tooltip, and thus, it takes a lot of space in
screen.

And it was not the intended visualization when the module was conceived,
just a side effect.

Thus, we restore what we expect, moving string to title for having the
tooltips again.

TT40169
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_stage/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_stage/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_stage/it/
weblate and others added 10 commits July 29, 2024 13:00
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_stage/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_stage/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_stage/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_stage/es/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_stage/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_task_stage
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_task_stage/sv/
@RogerSans RogerSans mentioned this pull request Jul 29, 2024
12 tasks
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor requests

hr_timesheet_task_stage/views/account_analytic_line.xml Outdated Show resolved Hide resolved
hr_timesheet_task_stage/views/account_analytic_line.xml Outdated Show resolved Hide resolved
hr_timesheet_task_stage/views/account_analytic_line.xml Outdated Show resolved Hide resolved
hr_timesheet_task_stage/views/account_analytic_line.xml Outdated Show resolved Hide resolved
@RogerSans RogerSans force-pushed the 17.0-mig-hr_timesheet_task_stage branch from 782dced to 5307215 Compare July 29, 2024 12:16
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@HaraldPanten
Copy link

@pedrobaeza The original PR seems to be abandoned. Do you mind closing the other and assign this migration to us?

THX in advance!

@pedrobaeza
Copy link
Member

/ocabot migration hr_timesheet_task_stage

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 30, 2024
Copy link

@luis-ron luis-ron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM 👍🏻

@RogerSans
Copy link
Author

@manuelregidor can you review this pls?

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-701-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 54e6785 into OCA:17.0 Jul 30, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2cbc333. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-hr_timesheet_task_stage branch July 30, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.