Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][IMP] Total of all rows in web_widget_x2many_2d_matrix #1043

Merged
merged 2 commits into from
Sep 20, 2018
Merged

[11.0][IMP] Total of all rows in web_widget_x2many_2d_matrix #1043

merged 2 commits into from
Sep 20, 2018

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Sep 20, 2018

This PR will add a cell to the right corner with the total of all the columns / rows.

image

astirpe
astirpe approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using this improvement in production (with module hr_timesheet_sheet) and it works fine.

simahawk
simahawk requested changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, otherwise LGTM:

  1. docstring missing
  2. can you update the screenshot in README?

web_widget_x2many_2d_matrix/static/src/js/2d_matrix_renderer.js Outdated
}
},

_renderTotalCell: function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring pls :)

simahawk
simahawk approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pedrobaeza pedrobaeza merged commit 4fea08d into OCA:11.0 Sep 20, 2018
alexey-pelykh pushed a commit to brainbeanapps/web that referenced this pull request Nov 9, 2018
@tarteo @alexey-pelykh
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
2d2fc0d
alexey-pelykh pushed a commit to brainbeanapps/web that referenced this pull request Nov 9, 2018
@tarteo @alexey-pelykh
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
47c09db
yajo pushed a commit that referenced this pull request Nov 20, 2018
@tarteo @yajo
[IMP] web_widget_x2many_2d_matrix: Total of all rows (#1043)
58e22f1
@tarteo tarteo deleted the 11-matrix-total branch November 26, 2019 08:27
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Jan 10, 2020
@tarteo @AdriaGForgeFlow
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
b2ad7a3
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Feb 14, 2020
@tarteo @AdriaGForgeFlow
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
8e25f2b
AdriaGForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Mar 5, 2020
@tarteo @AdriaGForgeFlow
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
09991cb
Saran440 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 13, 2020
@tarteo @Saran440
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
0c824e0
Saran440 pushed a commit to ecosoft-odoo/web that referenced this pull request Nov 13, 2020
@tarteo @Saran440
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
e3de0d4
pniederlag pushed a commit to datenbetrieb/web that referenced this pull request Dec 26, 2020
@tarteo @pniederlag
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
dccaa5b
ChrisOForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Dec 13, 2021
@tarteo @ChrisOForgeFlow
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
9019a97
LoisRForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Feb 18, 2022
@tarteo @LoisRForgeFlow
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
d5368b4
bizzappdev pushed a commit to bizzappdev/web that referenced this pull request Nov 5, 2022
@tarteo
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
9364ffb
JoanSForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Nov 14, 2022
@tarteo @JoanSForgeFlow
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
a7794c8
tarteo added a commit to tarteo/web that referenced this pull request Feb 28, 2023
@tarteo
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
56de5dd
PieterPaulussen pushed a commit to GumbysBE/web that referenced this pull request Apr 28, 2023
@tarteo @PieterPaulussen
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
15278c9
dreispt pushed a commit to ursais/web that referenced this pull request Jan 21, 2024
@tarteo @dreispt
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
710b773
norlinhenrik pushed a commit to norlinhenrik/web that referenced this pull request Jan 28, 2024
@tarteo @norlinhenrik
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
a891725
SodexisTeam pushed a commit to SodexisTeam/web that referenced this pull request Feb 29, 2024
@tarteo @SodexisTeam
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
7f0311a
mohs8421 pushed a commit to mohs8421/oca-web that referenced this pull request Jun 18, 2024
@tarteo @mohs8421
[IMP] web_widget_x2many_2d_matrix: Total of all rows (OCA#1043)
35a6032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astirpe astirpe astirpe approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarteo @simahawk @pedrobaeza @astirpe