[12.0][IMP] web_pwa_oca: Drop BeforeInstallPrompt #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eLBati, |
thomaspaulb
approved these changes
Dec 10, 2020
Tardo
force-pushed
the
12.0-imp-web_pwa_oca-install
branch
from
b3ba1fd to
4a293d8
Compare
pedrobaeza
reviewed
Dec 11, 2020
…led (only log). Otherwise, odoo is unavailable in private mode with Firefox Browser
|
Hi @Tardo and Tecnativa team. First, thanks a lot for this usefull module, I use since a month in production. i so made a patch on the top of your current PR to fix it. Tecnativa#2 (I PR against your PR to avoid conflict, because you are changing the line I want to change). thanks ! |
…-raised-firefox-private-mode [FIX] web_pwa_oca : do not raise an error if service workers is disabled (only log). Otherwise, odoo is unavailable in private mode with Firefox Browser
|
Changes done |
pedrobaeza
approved these changes
Dec 11, 2020
|
/ocabot merge major |
|
What a great day to merge this nice PR. Let's do it! |
marcelsavegnago
approved these changes
Dec 11, 2020
|
Congratulations, your PR was merged at c3c44ae. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeforeInstallPromptEvent is deprecated. See w3c/manifest#836
Currently only chrome support it... and can't be used for the purpose that is used in the module.
cc @Tecnativa TT23822
ping @thomaspaulb